Opened 4 months ago

Closed 4 months ago

#28974 closed defect (fixed)

android compiling error: 'errno' undeclared (first use in this function)

Reported by: n8fr8 Owned by: nickm
Priority: High Milestone: Tor: 0.3.5.x-final
Component: Core Tor Version: Tor: 0.3.5.6-rc
Severity: Normal Keywords: android, compile
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

make all-am
make[1]: Entering directory '/home/n8fr8/dev/repos/tor-android/external/tor'

CC src/lib/fs/freespace.o

src/lib/fs/freespace.c: In function 'tor_get_avail_disk_space':
src/lib/fs/freespace.c:59:3: error: 'errno' undeclared (first use in this function)

errno = ENOSYS;

src/lib/fs/freespace.c:59:3: note: each undeclared identifier is reported only once for each function it appears in
src/lib/fs/freespace.c:59:11: error: 'ENOSYS' undeclared (first use in this function)

errno = ENOSYS;


Makefile:9083: recipe for target 'src/lib/fs/freespace.o' failed
make[1]: * [src/lib/fs/freespace.o] Error 1
make[1]: Leaving directory '/home/n8fr8/dev/repos/tor-android/external/tor'
Makefile:5000: recipe for target 'all' failed
make:
* [all] Error 2

Child Tickets

Change History (7)

comment:1 Changed 4 months ago by n8fr8

Adding:

#include "errno.h"

into freespace.c
seems to fix this

comment:2 Changed 4 months ago by nickm

Milestone: Tor: 0.3.5.x-final

comment:3 Changed 4 months ago by nickm

Owner: set to nickm
Status: newaccepted

comment:4 Changed 4 months ago by nickm

Priority: MediumHigh
Status: acceptedneeds_review

See my branch bug28974_035 with PR at https://github.com/torproject/tor/pull/626 .

Any other bugs of this kind?

comment:5 Changed 4 months ago by n8fr8

Not yet. Everything builds after that fix, and testing is underway. So far so good.

comment:6 Changed 4 months ago by ahf

Status: needs_reviewmerge_ready

Patch looks good.

comment:7 Changed 4 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged to 0.3.5 and forward

Note: See TracTickets for help on using tickets.