Opened 7 months ago

Closed 6 months ago

#28979 closed defect (fixed)

Current alpha manual typo authorized_clients

Reported by: Felixix Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, doc, postfreeze-ok, 035-backport
Cc: Actual Points: 0
Parent ID: Points:
Reviewer: asn Sponsor:

Description

Manual text, key word Client Authorization mentions public-key vs privkey for service:

To configure client authorization on the service side, the "<HiddenServiceDir>/authorized_clients/" directory needs to exist. Each file in that directory should be suffixed with ".auth" (i.e. "alice.auth"; the file name is irrelevant) and its content format MUST be:
<auth-type>:<key-type>:<base32-encoded-public-key>
The supported <auth-type> are: "descriptor". The supported <key-type> are: "x25519". The <base32-encoded-privkey> is the base32 representation of the raw key bytes only (32 bytes for x25519).

rend-spec-v3.txt (4329f00194bdb7adff2c9daa1cf47b09ce4c2a9e) confirms public-key instead of privkey.
So privkey is wrong for service.

Child Tickets

Change History (7)

comment:1 Changed 7 months ago by nickm

Component: - Select a componentCore Tor/Tor
Keywords: tor-hs doc added
Milestone: Tor: 0.4.0.x-final

comment:2 Changed 6 months ago by nickm

Keywords: postfreeze-ok added

Mark some tickets as postfreeze-ok, to indicate that I think they are okay to accept in 0.4.0 post-freeze. Does not indicate that they are all necessary to do postfreeze.

comment:3 Changed 6 months ago by nickm

Actual Points: 0
Keywords: 035-backport added
Owner: set to nickm
Status: newaccepted

comment:4 Changed 6 months ago by nickm

Status: acceptedneeds_review

Fix in branch bug28979_035; PR at https://github.com/torproject/tor/pull/652

comment:5 Changed 6 months ago by dgoulet

Reviewer: asn

comment:6 Changed 6 months ago by asn

Status: needs_reviewmerge_ready

LGTM!

comment:7 Changed 6 months ago by nickm

Milestone: Tor: 0.4.0.x-finalTor: 0.3.5.x-final
Resolution: fixed
Status: merge_readyclosed

Thanks! Merged!

Note: See TracTickets for help on using tickets.