Opened 3 months ago

Closed 4 days ago

#28983 closed enhancement (implemented)

Work out how long it takes sbws to measure the network

Reported by: teor Owned by: juga
Priority: Medium Milestone: sbws: 1.1.x-final
Component: Core Tor/sbws Version:
Severity: Normal Keywords: no-changes-version
Cc: juga Actual Points:
Parent ID: Points: 1
Reviewer: asn Sponsor:

Description

In the bandwidth file, sbws should report how long it takes to measure (almost all) the entire network.

Here's one way we could work out the network measurement "half-life":

  1. Count the number of relays in the network, N
  2. Find the last N/2 successful, unique relay measurements
  3. Report how much time has elapsed since the earliest measurement in the list

(We use the half-life, so that failed measurements don't affect the final time too much.)

We could monitor this figure for each scanner, to make sure they are working correctly.

Child Tickets

Change History (14)

comment:1 Changed 3 months ago by teor

Milestone: sbws: 1.1.x-final

comment:2 Changed 2 weeks ago by juga

Keywords: no-changes-version added

Add keyword to help planify releases/milestones.
Tickets that doesn't imply a change of version are tickets which do not affect the code (docs, tests) and some time of refactors.

comment:3 Changed 2 weeks ago by juga

Points: 1

Add points

comment:4 Changed 13 days ago by juga

Owner: set to juga
Status: newassigned

comment:5 Changed 13 days ago by juga

Status: assignedneeds_revision

https://github.com/torproject/sbws/pull/350

(In revision until other tickets are merged).

comment:6 Changed 12 days ago by juga

Status: needs_revisionneeds_review

comment:7 Changed 7 days ago by asn

Reviewer: asn

comment:8 Changed 7 days ago by asn

Status: needs_reviewneeds_revision

Done an initial review here.

comment:9 Changed 6 days ago by juga

Status: needs_revisionneeds_review

I made a few changes, explained in the PR, i can explain them more if needed.

comment:10 Changed 6 days ago by asn

Looks almost ready. One small weirdness in the test.

comment:11 Changed 6 days ago by asn

Status: needs_reviewneeds_revision

comment:12 Changed 6 days ago by juga

Status: needs_revisionneeds_review

weirdness explained

comment:13 Changed 6 days ago by asn

Status: needs_reviewmerge_ready

LGTM! Thanks for the fixes!

comment:14 Changed 4 days ago by juga

Resolution: implemented
Status: merge_readyclosed

merged

Note: See TracTickets for help on using tickets.