Opened 6 months ago

Closed 6 months ago

#28994 closed defect (fixed)

Close stdout pipe on error in process_unix_exec (was double closing stdin pipe)

Reported by: kjak Owned by:
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: ahf Sponsor:

Description

When an error occurs and cleanup is being performed in process_unix_exec, the stdin pipe is currently being double closed instead of closing both the stdin and stdout pipes. This occurs in two places.

PR to follow.

Child Tickets

Change History (5)

comment:1 Changed 6 months ago by kjak

Status: newneeds_review

comment:2 Changed 6 months ago by nickm

Milestone: Tor: 0.4.0.x-final

comment:3 Changed 6 months ago by dgoulet

Reviewer: ahf

comment:4 Changed 6 months ago by ahf

Status: needs_reviewmerge_ready

Good catch! That's some bad copy and paste there.

I think this patch looks good. I don't think we need a changes file when this code isn't released yet, but please correct me if I am wrong.

comment:5 Changed 6 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

lgtm too; cherry-picked to master. Thanks! No changes file needed if bug is not in any released version.

Note: See TracTickets for help on using tickets.