Opened 5 months ago

Closed 5 months ago

#29015 closed defect (implemented)

Document tor_ersatz_socketpair() and the functions it calls

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version: Tor: 0.3.5.1-alpha
Severity: Normal Keywords: ipv6, easy, doc, fast-fix
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

The function comments in socketpair.c are missing or incomplete.

Maybe we should add function comments, using the tor_socketpair() comment as a starting point?
https://github.com/torproject/tor/blob/701eaef980de4f7dbb5c31c4fee9b7e1e266d7a1/src/lib/net/socket.c#L450

Child Tickets

Change History (7)

comment:1 Changed 5 months ago by teor

Keywords: 035-backport removed
Status: newneeds_review

See my pull request:
https://github.com/torproject/tor/pull/637

We don't need to backport doc changes.

comment:2 Changed 5 months ago by dgoulet

Reviewer: teor

comment:3 Changed 5 months ago by teor

Reviewer: teor

Hey dgoulet, I can't review my own stuff.

comment:4 Changed 5 months ago by teor

Actual Points: 0.1
Owner: set to teor
Points: 0.1
Status: needs_reviewassigned

comment:5 Changed 5 months ago by teor

Status: assignedneeds_review

comment:6 Changed 5 months ago by nickm

Parent ID: #28995

Removing parent relationship.

comment:7 Changed 5 months ago by nickm

Resolution: implemented
Status: needs_reviewclosed

lgtm; merged.

Note: See TracTickets for help on using tickets.