#29015 closed defect (implemented)

Document tor_ersatz_socketpair() and the functions it calls

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version: Tor:
Severity: Normal Keywords: ipv6, easy, doc, fast-fix
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: Sponsor:


The function comments in socketpair.c are missing or incomplete.

Maybe we should add function comments, using the tor_socketpair() comment as a starting point?

Child Tickets

Change History (7)

comment:1 Changed 19 months ago by teor

Keywords: 035-backport removed
Status: newneeds_review

See my pull request:

We don't need to backport doc changes.

comment:2 Changed 19 months ago by dgoulet

Reviewer: teor

comment:3 Changed 19 months ago by teor

Reviewer: teor

Hey dgoulet, I can't review my own stuff.

comment:4 Changed 19 months ago by teor

Actual Points: 0.1
Owner: set to teor
Points: 0.1
Status: needs_reviewassigned

comment:5 Changed 19 months ago by teor

Status: assignedneeds_review

comment:6 Changed 19 months ago by nickm

Parent ID: #28995

Removing parent relationship.

comment:7 Changed 19 months ago by nickm

Resolution: implemented
Status: needs_reviewclosed

lgtm; merged.

Note: See TracTickets for help on using tickets.