Provide a means to inform NoScript about being run in a Tor Browser context

Tor Browser has some special requirements which NoScript helps to fulfill. However, this kind of NoScript usage might come with a worse experience for non-Tor Browser NoScript users. Thus, it would be helpful for NoScript to know whether it is running in a Tor Browser context to be able to apply our needs only then.

Trac:
Parent Ticket: #27313 (moved)

added TorBrowserTeam201903R component::applications/tor browser noscript owner::tbb-team parent::27313 priority::very high resolution::fixed severity::normal status::closed tbb-8.5 type::task labels

What? In what way is that an enhancement? What prevents NoScript from adding a new checkbox "special requirements" in its options?

Trac:
Username: watt
Type: enhancement to task
Status: new to needs_information

That's a prerequisite for #27313 (moved) getting fixed.

Trac:
Parent: N/A to #27313 (moved)

Giorgio's suggestion was:

>
> > console.log(await browser.runtime.getBrowserInfo())
> 
> Object { name: "Firefox", vendor: "Mozilla", version: "60.1.0", buildID: "20180204020101" }
>
> 
> Maybe you could send an "isTorBrowser: true" additional property within your updateSettings messages.

Sounds like something we could test.

Trac:
Keywords: N/A deleted, TorBrowserTeam201902 added

Moving remaining tickets to March.

Trac:
Keywords: TorBrowserTeam201902 deleted, TorBrowserTeam201903 added

bug_29021 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_29021&id=3187dd92b4804c20fa08e225e629c3ec94eead03) has a small fix implementing Giorgio's suggestion. I verified that we are actually sending isTorBrowser: true and that we still get settings from NoScript back (even if it does not understand it yet).

mcs/brade: can you take a quick look at this patch? I'd like to get it into both the upcoming stable and alpha release. Thanks!

Trac:
Cc: ma1 to ma1, mcs, brade
Keywords: TorBrowserTeam201903 deleted, tbb-8.5, TorBrowserTeam201903R added
Priority: Medium to Very High
Status: needs_information to needs_review

R=Brade

Thanks! Merged to master (commit 3187dd92b4804c20fa08e225e629c3ec94eead03) and maint-2.0 (commit 9ad542c9a851ee531ff75773c763a17758867bdb).

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

Thank you! https://github.com/hackademix/noscript/releases/tag/10.2.2rc3 is the first version taking advantage of this.

closed

mentioned in issue #29733 (moved)

moved to tpo/applications/tor-browser#29021 (closed)