Opened 3 months ago

Closed 6 weeks ago

Last modified 5 weeks ago

#29021 closed task (fixed)

Provide a means to inform NoScript about being run in a Tor Browser context

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: noscript, TorBrowserTeam201903R, tbb-8.5
Cc: ma1, mcs, brade Actual Points:
Parent ID: #27313 Points:
Reviewer: Sponsor:

Description

Tor Browser has some special requirements which NoScript helps to fulfill. However, this kind of NoScript usage might come with a worse experience for non-Tor Browser NoScript users. Thus, it would be helpful for NoScript to know whether it is running in a Tor Browser context to be able to apply our needs only then.

Child Tickets

Change History (8)

comment:1 Changed 3 months ago by watt

Status: newneeds_information
Type: enhancementtask

What? In what way is that an enhancement? What prevents NoScript from adding a new checkbox "special requirements" in its options?

comment:2 Changed 8 weeks ago by gk

Parent ID: #27313

That's a prerequisite for #27313 getting fixed.

comment:3 Changed 8 weeks ago by gk

Keywords: TorBrowserTeam201902 added

Giorgio's suggestion was:

>
> > console.log(await browser.runtime.getBrowserInfo())
> 
> Object { name: "Firefox", vendor: "Mozilla", version: "60.1.0", buildID: "20180204020101" }
>
> 
> Maybe you could send an "isTorBrowser: true" additional property within your updateSettings messages.

Sounds like something we could test.

comment:4 Changed 6 weeks ago by gk

Keywords: TorBrowserTeam201903 added; TorBrowserTeam201902 removed

Moving remaining tickets to March.

comment:5 Changed 6 weeks ago by gk

Cc: mcs brade added
Keywords: TorBrowserTeam201903R tbb-8.5 added; TorBrowserTeam201903 removed
Priority: MediumVery High
Status: needs_informationneeds_review

bug_29021 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_29021&id=3187dd92b4804c20fa08e225e629c3ec94eead03) has a small fix implementing Giorgio's suggestion. I verified that we are actually sending isTorBrowser: true and that we still get settings from NoScript back (even if it does not understand it yet).

mcs/brade: can you take a quick look at this patch? I'd like to get it into both the upcoming stable and alpha release. Thanks!

comment:6 Changed 6 weeks ago by brade

R=Brade

comment:7 Changed 6 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks! Merged to master (commit 3187dd92b4804c20fa08e225e629c3ec94eead03) and maint-2.0 (commit 9ad542c9a851ee531ff75773c763a17758867bdb).

comment:8 Changed 5 weeks ago by ma1

Thank you!
https://github.com/hackademix/noscript/releases/tag/10.2.2rc3 is the first version taking advantage of this.

Note: See TracTickets for help on using tickets.