Opened 6 months ago

Closed 4 months ago

#29026 closed defect (fixed)

OpenSSL will not compile without engine support

Reported by: Mangix Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.3.4.10
Severity: Normal Keywords: 040-accepted-20190115, 040-backport, 035-backport, 034-backport, 033-backport, 029-backport, postfreeze-ok
Cc: Actual Points:
Parent ID: Points:
Reviewer: ahf Sponsor:

Description

Tor currently disables its engine support for Android only. This breaks compilation on other platforms that lack engine support.

This patch changes the check to check for OPENSSL_NO_ENGINE, which should work everywhere.

Child Tickets

Attachments (3)

010-openssl-engines.patch​ (1.0 KB) - added by Mangix 6 months ago.
k​ (896 bytes) - added by Mangix 5 months ago.
ENGINES
z​ (1.5 KB) - added by Mangix 5 months ago.
deprecated APIs

Download all attachments as: .zip

Change History (10)

Changed 6 months ago by Mangix

Attachment: 010-openssl-engines.patch​ added

comment:1 Changed 6 months ago by ahf

Component: Core Tor → Core Tor/Tor
Milestone: → Tor: unspecified
Reviewer: → ahf
Status: assigned → needs_review

Marking as needs review.

comment:2 Changed 6 months ago by nickm

Keywords: 040-proposed *-backport added

Changed 5 months ago by Mangix

Attachment: k​ added

ENGINES

Changed 5 months ago by Mangix

Attachment: z​ added

deprecated APIs

comment:3 Changed 5 months ago by Mangix

Original patch was for 0.3.4. These are for 0.3.5. First patch fixes the issue in this ticket. The second fixes compilation without deprecated OpenSSL APIs.

comment:4 Changed 5 months ago by teor

Keywords: 040-accepted-20190115 040-backport 035-backport 034-backport 033-backport 029-backport added; 040-proposed *-backport removed
Milestone: Tor: unspecified → Tor: 0.4.0.x-final

I think we accepted this ticket in the meeting.

comment:5 Changed 5 months ago by nickm

Keywords: postfreeze-ok added

Mark some tickets as postfreeze-ok, to indicate that I think they are okay to accept in 0.4.0 post-freeze. Does not indicate that they are all necessary to do postfreeze.

comment:6 Changed 5 months ago by nickm

Milestone: Tor: 0.4.0.x-final → Tor: 0.3.5.x-final
Status: needs_review → merge_ready

These look good to me; let's take them in 0.3.5. (I'm okay with no backport, since 0.3.5 is LTS.)

I've put them in a branch called ticket29026_035 with a PR at ​https://github.com/torproject/tor/pull/689 -- let's merge if the CI tests all pass.

comment:7 Changed 4 months ago by asn

Resolution: → fixed
Status: merge_ready → closed

Merged and backported to 035.

Note: See TracTickets for help on using tickets.