Opened 6 weeks ago
Closed 6 days ago
#29026 closed defect (fixed)
OpenSSL will not compile without engine support
| Reported by: | Mangix | Owned by: | |
|---|---|---|---|
| Priority: | Medium | Milestone: | Tor: 0.3.5.x-final |
| Component: | Core Tor/Tor | Version: | Tor: 0.3.4.10 |
| Severity: | Normal | Keywords: | 040-accepted-20190115, 040-backport, 035-backport, 034-backport, 033-backport, 029-backport, postfreeze-ok |
| Cc: | Actual Points: | ||
| Parent ID: | Points: | ||
| Reviewer: | ahf | Sponsor: |
Description
Tor currently disables its engine support for Android only. This breaks compilation on other platforms that lack engine support.
This patch changes the check to check for OPENSSL_NO_ENGINE, which should work everywhere.
Child Tickets
Attachments (3)
Change History (10)
Changed 6 weeks ago by
| Attachment: | 010-openssl-engines.patch added |
|---|
comment:1 Changed 6 weeks ago by
| Component: | Core Tor → Core Tor/Tor |
|---|---|
| Milestone: | → Tor: unspecified |
| Reviewer: | → ahf |
| Status: | assigned → needs_review |
comment:2 Changed 6 weeks ago by
| Keywords: | 040-proposed *-backport added |
|---|
comment:3 Changed 5 weeks ago by
Original patch was for 0.3.4. These are for 0.3.5. First patch fixes the issue in this ticket. The second fixes compilation without deprecated OpenSSL APIs.
comment:4 Changed 5 weeks ago by
| Keywords: | 040-accepted-20190115 040-backport 035-backport 034-backport 033-backport 029-backport added; 040-proposed *-backport removed |
|---|---|
| Milestone: | Tor: unspecified → Tor: 0.4.0.x-final |
I think we accepted this ticket in the meeting.
comment:5 Changed 5 weeks ago by
| Keywords: | postfreeze-ok added |
|---|
Mark some tickets as postfreeze-ok, to indicate that I think they are okay to accept in 0.4.0 post-freeze. Does not indicate that they are all necessary to do postfreeze.
comment:6 Changed 12 days ago by
| Milestone: | Tor: 0.4.0.x-final → Tor: 0.3.5.x-final |
|---|---|
| Status: | needs_review → merge_ready |
These look good to me; let's take them in 0.3.5. (I'm okay with no backport, since 0.3.5 is LTS.)
I've put them in a branch called ticket29026_035 with a PR at https://github.com/torproject/tor/pull/689 -- let's merge if the CI tests all pass.
comment:7 Changed 6 days ago by
| Resolution: | → fixed |
|---|---|
| Status: | merge_ready → closed |
Merged and backported to 035.
Marking as needs review.