Make "tried to establish rendezvous on non-OR circuit" into a protocol warning

There's nothing that relay operators can do to fix it.

changed milestone to %Tor: 0.2.9.x-final

Trac:
Parent Ticket: #15618 (moved)

added 029-backport 033-backport 034-backport 035-backport 040-accepted-20190115 040-backport actualpoints::0.2 component::core tor/tor fast-fix milestone::Tor: 0.2.9.x-final owner::teor parent::15618 points::0.1 postfreeze-ok priority::medium resolution::fixed reviewer::asn severity::normal status::closed tor-hs type::defect version::tor 0.2.5.7-rc labels

I have a draft pull request here: https://github.com/torproject/tor/pull/641

It needs a changes file, and a bug fix release.

Trac:
Status: assigned to needs_revision

+1

I accidentally put that branch in torproject/tor, so the pusher deleted it.

Here's a new branch with the 029 merge: https://github.com/torproject/tor/pull/642

And here's the master merge, which git merged automatically: https://github.com/torproject/tor/pull/643

Trac:
Status: needs_revision to needs_review
Actualpoints: 0.1 to 0.2
Version: Tor: unspecified to Tor: 0.2.5.7-rc

The master merge failed due to the unrelated bug #29036 (moved).

Trac:
Keywords: N/A deleted, 040-proposed-fast-fix added

Trac:
Milestone: Tor: 0.4.1.x-final to Tor: 0.4.0.x-final

+1.

Agreed, too often reported and annoying for users that run relays but don't exactly understand the warning and ask themselves if there's something they should do about it. We'll keep track of it in the parent ticket and hopefully get to the bottom of it at some time.

Trac:
Keywords: 041-proposed-fast-fix deleted, N/A added

Trac:
Reviewer: N/A to asn

We accepted this in the meeting

Trac:
Keywords: 040-proposed-fast-fix deleted, 040-accepted-20190115 added

Mark some tickets as postfreeze-ok, to indicate that I think they are okay to accept in 0.4.0 post-freeze. Does not indicate that they are all necessary to do postfreeze.

Trac:
Keywords: N/A deleted, postfreeze-ok added

LGTM! Thanks for this!

Trac:
Status: needs_review to merge_ready

I'm fine with this, but it needs a changes file though.

Trac:
Status: merge_ready to needs_revision

Replying to nickm:

I'm fine with this, but it needs a changes file though.

There is a changes file at changes/bug29029 in commit 89a0b77 in https://github.com/torproject/tor/pull/642

Which pull request are you looking at?

Trac:
Status: needs_revision to merge_ready

I can no longer find the PR I was looking at before, unless it was 641 (‽), which isn't what I should be looking at.

Let's take this in 0.4.0.2-alpha.

Merged to 0.2.9 and forward!

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

Trac:
Milestone: Tor: 0.4.0.x-final to Tor: 0.2.9.x-final