Opened 7 months ago

Closed 7 months ago

Last modified 5 months ago

#29029 closed defect (fixed)

Make "tried to establish rendezvous on non-OR circuit" into a protocol warning

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version: Tor: 0.2.5.7-rc
Severity: Normal Keywords: tor-hs, fast-fix, 040-accepted-20190115, 040-backport, 035-backport, 034-backport, 033-backport, 029-backport, postfreeze-ok
Cc: s7r, dhalgren.tor@…, phoul Actual Points: 0.2
Parent ID: #15618 Points: 0.1
Reviewer: asn Sponsor:

Description

There's nothing that relay operators can do to fix it.

Child Tickets

Change History (17)

comment:1 Changed 7 months ago by teor

Status: assignedneeds_revision

I have a draft pull request here:
https://github.com/torproject/tor/pull/641

It needs a changes file, and a bug fix release.

comment:2 Changed 7 months ago by dgoulet

+1

comment:3 Changed 7 months ago by teor

Actual Points: 0.10.2
Status: needs_revisionneeds_review
Version: Tor: unspecifiedTor: 0.2.5.7-rc

I accidentally put that branch in torproject/tor, so the pusher deleted it.

Here's a new branch with the 029 merge:
https://github.com/torproject/tor/pull/642

And here's the master merge, which git merged automatically:
https://github.com/torproject/tor/pull/643

comment:4 Changed 7 months ago by teor

The master merge failed due to the unrelated bug #29036.

comment:5 Changed 7 months ago by teor

Keywords: 040-proposed-fast-fix added

comment:6 Changed 7 months ago by teor

Milestone: Tor: 0.4.1.x-finalTor: 0.4.0.x-final

comment:7 Changed 7 months ago by s7r

+1.

Agreed, too often reported and annoying for users that run relays but don't exactly understand the warning and ask themselves if there's something they should do about it. We'll keep track of it in the parent ticket and hopefully get to the bottom of it at some time.

comment:8 Changed 7 months ago by teor

Keywords: 041-proposed-fast-fix removed

comment:9 Changed 7 months ago by asn

Reviewer: asn

comment:10 Changed 7 months ago by teor

Keywords: 040-accepted-20190115 added; 040-proposed-fast-fix removed

We accepted this in the meeting

comment:11 Changed 7 months ago by nickm

Keywords: postfreeze-ok added

Mark some tickets as postfreeze-ok, to indicate that I think they are okay to accept in 0.4.0 post-freeze. Does not indicate that they are all necessary to do postfreeze.

comment:12 Changed 7 months ago by asn

Status: needs_reviewmerge_ready

LGTM! Thanks for this!

comment:13 Changed 7 months ago by nickm

Status: merge_readyneeds_revision

I'm fine with this, but it needs a changes file though.

comment:14 in reply to:  13 Changed 7 months ago by teor

Status: needs_revisionmerge_ready

Replying to nickm:

I'm fine with this, but it needs a changes file though.

There is a changes file at changes/bug29029 in commit 89a0b77 in https://github.com/torproject/tor/pull/642

Which pull request are you looking at?

comment:15 Changed 7 months ago by nickm

I can no longer find the PR I was looking at before, unless it was 641 (‽), which isn't what I should be looking at.

Let's take this in 0.4.0.2-alpha.

comment:16 Changed 7 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged to 0.2.9 and forward!

comment:17 Changed 5 months ago by teor

Milestone: Tor: 0.4.0.x-finalTor: 0.2.9.x-final
Note: See TracTickets for help on using tickets.