Opened 2 months ago

Closed 8 weeks ago

#29035 closed task (fixed)

Post-YE campaign clean up

Reported by: pili Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Minor Keywords: TorBrowserTeam201901R, GeorgKoppen201901
Cc: sstevenson, antonela, steph, gk, mcs, brade, igt0 Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

After the YE fundraising campaign we need to remove the banner from Tor Browser and figure out what to have instead.

The proposal so far is to remove the banner altogether and add a link to

e.g https://trac.torproject.org/projects/tor/attachment/ticket/27097/27097_4_screenshot.png

Child Tickets

Attachments (2)

TBA Welcome Page.png (131.7 KB) - added by antonela 2 months ago.
TB8 - Bottom - Link + Icon.png (333.3 KB) - added by antonela 2 months ago.

Download all attachments as: .zip

Change History (27)

comment:1 Changed 2 months ago by pili

Cc: emmapeel added

Will need to be localised also

comment:2 Changed 2 months ago by gk

Keywords: TorBrowserTeam201901 added

comment:3 Changed 2 months ago by antonela

Cc: emmapeel removed
Keywords: TorBrowserTeam201901 removed

I made a version with an icon (A) and a version without (B)

(A) https://marvelapp.com/a131e34/screen/52273353
(B) https://marvelapp.com/a131e34/screen/52273349

I prefer the non-icon one, but I see how the icon highlight it a bit more.

Assets are ready to be grabbed on /handoff and there is a PR from Arthur here
https://github.com/arthuredelstein/torbutton/commit/27097+4

comment:4 in reply to:  3 ; Changed 2 months ago by gk

Keywords: TorBrowserTeam201901 added

Replying to antonela:

I made a version with an icon (A) and a version without (B)

(A) https://marvelapp.com/a131e34/screen/52273353
(B) https://marvelapp.com/a131e34/screen/52273349

I prefer the non-icon one, but I see how the icon highlight it a bit more.

Assets are ready to be grabbed on /handoff and there is a PR from Arthur here
https://github.com/arthuredelstein/torbutton/commit/27097+4

That's for the old newsletter sign-up work. Did you mean to add a new pull request? Or did you mean we should essentially use the code there and just replace icons? Or...?

comment:5 in reply to:  4 Changed 2 months ago by antonela

Replying to gk:

That's for the old newsletter sign-up work. Did you mean to add a new pull request? Or did you mean we should essentially use the code there and just replace icons? Or...?

Yes, is the same. We can use that code and if we want the icon, just add the icon.

comment:6 Changed 2 months ago by sstevenson

I prefer the icon because it makes it stand out more.

comment:7 Changed 2 months ago by gk

What do we plan to do on mobile? There is the donation banner available as well currently.

comment:8 Changed 2 months ago by sstevenson

Isa would like to do the same thing on mobile - no banner, but have the newsletter sign up on the about:tor page.

comment:9 Changed 2 months ago by gk

Keywords: GeorgKoppen201901 added

Changed 2 months ago by antonela

Attachment: TBA Welcome Page.png added

Changed 2 months ago by antonela

comment:10 Changed 2 months ago by antonela

Mobile

https://trac.torproject.org/projects/tor/raw-attachment/ticket/29035/TBA%20Welcome%20Page.png

Desktop

https://trac.torproject.org/projects/tor/raw-attachment/ticket/29035/TB8%20-%20Bottom%20-%20Link%20%2B%20Icon.png

comment:11 Changed 2 months ago by steph

The signup part looks good! We just talked this over in the comms meeting, and both versions should match. Can we also add the manual and the mission lines to TBA? Isa suggested making it responsive so it's easy to maintain.

comment:12 Changed 2 months ago by gk

Cc: mcs brade added
Keywords: TorBrowserTeam201901R added; TorBrowserTeam201901 removed
Status: newneeds_review

I pushed bug_29035_v2 (https://gitweb.torproject.org/user/gk/torbutton.git/log/?h=bug_29035_v2) which contains a) the reverts of all the previous donations and the newsletter signup related commits and b) I added the signup link (the text is not vertically aligned, though, we which seems to be okay).

mcs/brade: I plan to group the revert commits by feature when squashing the branch but I thought having them as they are right now might make reviewing easier. Could you have a look at the desktop version already while I am working on the mobile one? (I need to adapt the stable maint-branch, too, which needs some time, hence the early review request).

comment:13 Changed 2 months ago by mcs

This was a little challenging to review, but Kathy and I think you got it right. Our only comment is that you forgot to add the new image (icon-newsletter.png).

comment:14 in reply to:  13 Changed 2 months ago by gk

Replying to mcs:

This was a little challenging to review, but Kathy and I think you got it right. Our only comment is that you forgot to add the new image (icon-newsletter.png).

Oops, fixed. Sorry for the hassle, I'll move forward regrouping the revert-commits and clean things up and then work on the Android part, thanks.

comment:15 Changed 2 months ago by gk

Keywords: TorBrowserTeam201901 added; TorBrowserTeam201901R removed
Status: needs_reviewnew

comment:16 in reply to:  11 Changed 2 months ago by gk

Replying to steph:

The signup part looks good! We just talked this over in the comms meeting, and both versions should match. Can we also add the manual and the mission lines to TBA? Isa suggested making it responsive so it's easy to maintain.

In principle, yes, that should be doable. We should think about how those additional lines should look like. If you look at the mobile part in comment:10 you see that already the single line for the news sign-up is broken into three lines on mobile. I doubt we want to clutter the whole mobile screen with all of the text from the manual, newsletter sign-up, and of project mission.

comment:17 Changed 2 months ago by gk

Cc: stevenson igt0 added; sstevenson removed
Keywords: TorBrowserTeam201901R added; TorBrowserTeam201901 removed
Status: newneeds_review

bug_29035_v3 has the patches for review. There are essentially three parts: 1) removing the donation banner related changes (commit 9b4c56f050a266bbcd04d6985ee46f9da612e0e7), 2) removing the newsletter sign-up banner changes (8d3c6f996c943399a1505646eee14ce81868c0c8), and 3) adding the code changes for the new sign-up message/link on desktop and mobile (commit e73ff049acb16d410083c9cad64da678aab30294).

I made it so that the whole sign-up related text and icon are on a single line on tablets, laptops, and desktops while on phones it has the three lines as outlined in comment:10. I am fine adjusting that as needed or making it more complex, like on a phone in landscape mode show the single line, too. I am not a web developer, so I don't have that strong opinions here.

A mobile bundle for testing can be found at:

https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-android-armv7-multi-qa_29035.apk
https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-android-armv7-multi-qa_29035.apk.asc

steph: #28145 is the ticket for the remaining links on about:tor should be doable for the next release provided we are sure how this should look like.

comment:18 Changed 2 months ago by gk

Cc: sstevenson added; stevenson removed

comment:19 Changed 2 months ago by gk

bug_29035_maint20_v2 (https://gitweb.torproject.org/user/gk/torbutton.git/log/?h=bug_29035_maint20_v2) has the four backported patches for the stable series for review.

comment:20 Changed 2 months ago by gk

Actually, let's have bug_29035_maint20_v3 (https://gitweb.torproject.org/user/gk/torbutton.git/log/?h=bug_29035_maint20_v3) for review for the stable series as it contains the newsletter icon, too.

comment:21 Changed 2 months ago by gk

I updated the code for the master branch a bit to fold in two fixups while going over _v3 again and preparing the maint-2.0 patch:

1) I added a missing ")"
2) I removed

body[mobile] .newsletter {
  display: block;
}

which is wrong (not needed).

bug_29035_v4 (https://gitweb.torproject.org/user/gk/torbutton.git/log/?h=bug_29035_v4) is the latest branch to review.

comment:22 Changed 2 months ago by mcs

r=brade, r=mcs
Both bug_29035_maint20_v3 and bug_29035_v4 look good to us.

comment:23 Changed 2 months ago by igt0

the id=botton is left aligned within the torcontent-container. Should it not be centralized? (I am looking in a mobile device)

comment:24 in reply to:  23 Changed 2 months ago by gk

Replying to igt0:

the id=botton is left aligned within the torcontent-container. Should it not be centralized? (I am looking in a mobile device)

I think the plan was to provide a similar experience as on desktop if possible. So, that should be fine.

To move forward with the stable release I've applied the bug_29035_maint20_v3 patches to maint-2.0 (commits
fcbc57dc246ff38d7b04618ccab589c6cf33bad3
7a67c517617376f296612a5641e58e024b0aa0cc
75ab7ad9c1450d5c93ed94b6b140cc7144d2460c
ad06d1ca99f2dfd110ca10349db6c4a889f67d48).

On master the ones for bug_29035_v4 landed (commits
648b643cf9bc828e409cd07e7633f2c226b6ce7f
4f8bf590850eb72dc95a2c83b7cb78f03ef67f49
3edfe4d54f22d81c61b68c3760cc8320ce45fe42
c097649928aebba435f0379151c25388c924f3cb).

igt0: let me know whether we should make further changes for mobile. I'll leave this ticket open for that case for now.

comment:25 Changed 8 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

We are done here I think (igt0: again, please reopen or file a new ticket if you think we should change things).

Note: See TracTickets for help on using tickets.