Error loading private key after 0.3.5.7 upgrade

changed milestone to %Tor: 0.3.5.x-final

added 035-proposed actualpoints::.1 component::core tor/tor milestone::Tor: 0.3.5.x-final owner::nickm priority::very high regression reporter::anong resolution::fixed reviewer::ahf severity::critical status::closed tor-relay type::defect version::tor 0.3.5.7 labels

After downgrading to 0.3.4.9-5~bpo9+1 from ftp.debian.org/debian stretch-backports, everything is working again.

Trac:
Username: anong

Trac:
Priority: High to Very High
Milestone: N/A to Tor: 0.3.5.x-final

Are there any other logs around that error?

root@DietPi:~# Jan 10 11:21:37.158 [notice] Tor 0.3.5.7 running on Linux with Libevent 2.0.21-stable, OpenSSL 1.1.0j, Zlib 1.2.8, Liblzma 5.2.2, and Libzstd 1.1.2. Jan 10 11:21:37.158 [notice] Tor can't help you if you use it wrong! Learn how to be safe at https://www.torproject.org/download/download#warning Jan 10 11:21:37.159 [notice] Read configuration file "/etc/tor/torrc". Jan 10 11:21:37.174 [warn] Skipping obsolete configuration option 'SocksListenAddress' d! You should upgrade your Tor controller as soon as possible. Jan 10 11:21:37.178 [notice] You configured a non-loopback address '192.168.100.9:9050' for SocksPort. This allows everybody on your local network to use your machine as a proxy. Make sure this is what you wanted. Jan 10 11:21:37.178 [notice] Opening Socks listener on 192.168.100.9:9050 Jan 10 11:21:37.178 [notice] Opened Socks listener on 192.168.100.9:9050 Jan 10 11:21:37.178 [notice] Opening Control listener on 127.0.0.1:9051 Jan 10 11:21:37.178 [notice] Opened OR listener on 0.0.0.0:443 Jan 10 11:21:37.179 [notice] Opening Directory listener on 0.0.0.0:80 Jan 10 11:21:56.479 [notice] Tor can't help you if you use it wrong! Learn how to be safe at https://www.torproject.org/download/download#warning Jan 10 11:21:56.479 [notice] Read configuration file "/etc/tor/torrc". Jan 10 11:22:27.000 [err] Error loading private key. Jan 10 11:22:27.000 [err] Error initializing keys; exiting

That's all I have. What specific logs are you looking for?

Trac:
Username: anong

Debug log:

Jan 14 14:52:43 DietPi Tor[1561]: circuit_build_times_add_time(): Adding circuit build time 4725 Jan 14 14:52:43 DietPi Tor[1561]: circuit_build_times_add_time(): Adding circuit build time 2147483646 Jan 14 14:52:43 DietPi Tor[1561]: circuit_build_times_add_time(): Adding circuit build time 375 Jan 14 14:52:43 DietPi Tor[1561]: circuit_build_times_parse_state(): Loaded 273/273 values from 74 lines in circuit time histogram Jan 14 14:52:43 DietPi Tor[1561]: circuit_build_times_get_xm(): Xm mode #0: 525 19 Jan 14 14:52:43 DietPi Tor[1561]: circuit_build_times_set_timeout_worker(): Circuit build measurement period of 38477ms is more than twice the maximum build time we have ever observed. Capping it to 34650ms. Jan 14 14:52:43 DietPi Tor[1561]: circuit_build_times_set_timeout(): Based on 273 circuit times, it looks like we don't need to wait so long for circuits to finish. We will now assume a circuit is too slow to use after waiting 5 seconds Jan 14 14:52:43 DietPi Tor[1561]: circuit_build_times_set_timeout(): Circuit timeout data: 5274.074997ms, 60000.000000ms, Xm: 525, a: 0.697584, r: 0.271062 Jan 14 14:52:43 DietPi Tor[1561]: read_file_to_str(): Could not open "/var/lib/tor/router-stability": No such file or directory Jan 14 14:52:43 DietPi Tor[1561]: check_private_dir(): stat()ing /var/lib/tor/diff-cache Jan 14 14:53:13 DietPi Tor[1561]: kist_scheduler_run_interval(): KISTSchedRunInterval=0, turning to the consensus. Jan 14 14:53:13 DietPi Tor[1561]: scheduler_can_use_kist(): Determined KIST sched_run_interval should be 10. Can use KIST. Jan 14 14:53:13 DietPi Tor[1561]: scheduler_kist_set_full_mode(): Setting KIST scheduler with kernel support (KIST mode) Jan 14 14:53:13 DietPi Tor[1561]: kist_scheduler_run_interval(): KISTSchedRunInterval=0, turning to the consensus. Jan 14 14:53:13 DietPi Tor[1561]: cmux_ewma_set_options(): Enabled cell_ewma algorithm because of value in CircuitPriorityHalflifeMsec in consensus; scale factor is 0.793701 per 10 seconds Jan 14 14:53:13 DietPi Tor[1561]: Parsing GEOIP IPv4 file /usr/share/tor/geoip. Jan 14 14:53:14 DietPi Tor[1561]: Parsing GEOIP IPv6 file /usr/share/tor/geoip6. Jan 14 14:53:15 DietPi Tor[1561]: options_act(): Configured to measure hidden service statistics. Jan 14 14:53:15 DietPi Tor[1561]: Configured to measure statistics. Look for the *-stats files that will first be written to the data directory in 24 hours from now. Jan 14 14:53:15 DietPi Tor[1561]: mark_my_descriptor_dirty(): Decided to publish new relay descriptor: config change Jan 14 14:53:15 DietPi Tor[1561]: add_predicted_port(): New port prediction added. Will continue predictive circ building for 2909 more seconds. Jan 14 14:53:15 DietPi Tor[1561]: crypto_openssl_late_init(): NOT using OpenSSL engine support. Jan 14 14:53:15 DietPi Tor[1561]: evaluate_evp_for_aes(): This version of OpenSSL has a known-good EVP counter-mode implementation. Using it. Jan 14 14:53:15 DietPi Tor[1561]: file_status(): stat()ing /var/lib/tor/unparseable-descs Jan 14 14:53:15 DietPi Tor[1561]: check_private_dir(): stat()ing /var/lib/tor Jan 14 14:53:15 DietPi Tor[1561]: tor_getpwnam(): Caching new entry tor for tor Jan 14 14:53:15 DietPi Tor[1561]: check_private_dir(): stat()ing /var/lib/tor/keys Jan 14 14:53:15 DietPi Tor[1561]: tor_getpwnam(): Caching new entry tor for tor Jan 14 14:53:15 DietPi Tor[1561]: init_keys(): Reading/making identity key "/var/lib/tor/keys/secret_id_key"... Jan 14 14:53:15 DietPi Tor[1561]: file_status(): stat()ing /var/lib/tor/keys/secret_id_key Jan 14 14:53:15 DietPi Tor[1561]: Error loading private key. Jan 14 14:53:15 DietPi Tor[1561]: Error initializing keys; exiting Jan 14 14:53:15 DietPi Tor[1561]: tor_rename(): Renaming /var/lib/tor/state.tmp to /var/lib/tor/state Jan 14 14:53:15 DietPi Tor[1561]: or_state_save(): Saved state to "/var/lib/tor/state" Jan 14 14:53:15 DietPi Tor[1561]: channel_tls_free_all(): Shutting down TLS channels... Jan 14 14:53:15 DietPi Tor[1561]: channel_tls_free_all(): Done shutting down TLS channels Jan 14 14:53:15 DietPi Tor[1561]: channel_free_all(): Shutting down channels... Jan 14 14:53:15 DietPi Tor[1561]: channel_free_all(): Freeing channel_identity_map Jan 14 14:53:15 DietPi Tor[1561]: channel_free_all(): Freeing channel_gid_map Jan 14 14:53:15 DietPi Tor[1561]: channel_free_all(): Done cleaning up after channels Jan 14 14:53:15 DietPi Tor[1561]: connection_free_minimal(): closing fd 6. Jan 14 14:53:15 DietPi Tor[1561]: connection_free_minimal(): closing fd 7. Jan 14 14:53:15 DietPi Tor[1561]: connection_free_minimal(): closing fd 8. Jan 14 14:53:15 DietPi Tor[1561]: connection_free_minimal(): closing fd 9. Jan 14 14:53:15 DietPi Tor[1561]: connection_free_minimal(): closing fd 10. Jan 14 14:53:15 DietPi Tor[1561]: scheduler_free_all(): Shutting down scheduler Jan 14 14:53:15 DietPi Tor[1561]: tor_lockfile_unlock(): Unlocking "/var/lib/tor/lock"

Trac:
Username: anong

Seems this had something to do with the line endings. After running dos2unix on secret_id_key, everything works fine now. Interesting that 0.3.5.7 is the first version that had a problem with the file.

Trac:
Username: anong

Not necessarily: we changed how we parsed PEM stuff recently (I think in 0.3.5) to use Tor's base64 code instead of OpenSSL's. It's possible that OpenSSL is more newline-tolerant. If so, we should think about fixing that, if we can do so safely.

Trac:
Status: new to accepted
Keywords: N/A deleted, 035-proposed added
Owner: N/A to nickm

I've written a patch as bug29042_035 with PR at https://github.com/torproject/tor/pull/649 to improve the logging in this case. Needs review.

Trac:
Keywords: 035-proposed deleted, 035-proposed regression added
Status: accepted to needs_review
Actualpoints: N/A to .1

Trac:
Reviewer: N/A to ahf

LGTM.

Trac:
Status: needs_review to merge_ready

thanks; merged it!

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

closed

added 48m of time spent

moved to tpo/core/tor#29042 (closed)

Error loading private key after 0.3.5.7 upgrade

Child items ...

Activity