Opened 5 months ago

Last modified 4 months ago

#29053 new enhancement

Use descriptor structs to deterministically create descriptor dumps

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt
Cc: Actual Points:
Parent ID: Points: 2
Reviewer: Sponsor: SponsorV-can


We should make router_dump_router_to_string() and extrainfo_dump_to_string() deterministic transforms of routerinfo_t and extrainfo_t.

At the moment, these functions access options, internal state, and statistics files. If all those accesses occurred in router_build_fresh_unsigned_{router,extra}info() then the dump functions would be a lot easier to test.

Child Tickets

Change History (3)

comment:1 Changed 5 months ago by teor

I don't think we have time for this in 0.4.1, and I think it's out of scope for Sponsor V. But I'll ask the team next meeting.

comment:2 Changed 4 months ago by teor

Keywords: 041-proposed removed

I think our consensus is that this ticket would be cool, but it's out of scope for 0.4.1.

comment:3 Changed 4 months ago by teor

Parent ID: #29017

Un-parenting this, because it is out of scope for 041.

Note: See TracTickets for help on using tickets.