Opened 8 months ago

Closed 7 months ago

#29061 closed defect (fixed)

shellcheck: test_bt.sh issue

Reported by: rl1987 Owned by:
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description

In test_bt.sh line 6:
ulimit -c 0
       ^-- SC2039: In POSIX sh, ulimit -c is undefined.

Child Tickets

Change History (7)

comment:1 Changed 8 months ago by rl1987

Status: newneeds_review

comment:2 Changed 8 months ago by nickm

Milestone: Tor: 0.4.1.x-final

comment:3 Changed 7 months ago by dgoulet

Reviewer: nickm

comment:4 Changed 7 months ago by nickm

Status: needs_reviewneeds_revision

Hmmm. I'm a little worried here. None of our other test scripts require bash, and we want them to be able to run everywhere. If we're going to make this one require bash, we need to make sure that bash is actually installed on the host before we run this test.

Is there a POSIX alternative to ulimit -c that we could use here?

comment:5 Changed 7 months ago by rl1987

Status: needs_revisionneeds_review

Fixing this differently in:

comment:6 Changed 7 months ago by nickm

Status: needs_reviewmerge_ready

Thanks! This looks good to me to be squashed and merged in 0.4.1, assuming the CI passes.w

comment:7 Changed 7 months ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

Merged in master! Thanks!

Note: See TracTickets for help on using tickets.