Opened 8 months ago

Closed 7 months ago

#29063 closed defect (fixed)

shellcheck: test_rebind.sh issues

Reported by: rl1987 Owned by:
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt 041-proposed
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

In test_rebind.sh line 18:
clean () { test -n "$tmpdir" && test -d "$tmpdir" && rm -rf "$tmpdir" || :; }
                                                  ^-- SC2015: Note that A && B || C is not if-then-else. C may run when A is true.


In test_rebind.sh line 21:
tmpdir="`mktemp -d -t tor_rebind_test.XXXXXX`"
        ^-- SC2006: Use $(..) instead of legacy `..`.

Child Tickets

Change History (6)

comment:1 Changed 8 months ago by rl1987

Status: newneeds_review

comment:2 Changed 8 months ago by nickm

Keywords: 041-proposed added
Milestone: Tor: unspecified

comment:3 Changed 7 months ago by dgoulet

Reviewer: dgoulet

comment:4 Changed 7 months ago by dgoulet

Status: needs_reviewmerge_ready

comment:5 Changed 7 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.4.1.x-final

comment:6 Changed 7 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged to master.

Note: See TracTickets for help on using tickets.