Opened 6 months ago

Closed 5 months ago

#29064 closed defect (fixed)

shellcheck: test_rust.sh issues

Reported by: rl1987 Owned by: rl1987
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt
Cc: Actual Points:
Parent ID: Points:
Reviewer: catalyst Sponsor:

Description

In test_rust.sh line 19:
	    "${CARGO:-cargo}" test ${CARGO_ONLINE-"--frozen"} \
                                   ^-- SC2086: Double quote to prevent globbing and word splitting.


In test_rust.sh line 21:
            --target $rustc_host \
                     ^-- SC2086: Double quote to prevent globbing and word splitting.


In test_rust.sh line 22:
	    ${EXTRA_CARGO_OPTIONS} \
            ^-- SC2086: Double quote to prevent globbing and word splitting.

Child Tickets

Change History (9)

comment:1 Changed 6 months ago by rl1987

Owner: set to rl1987
Status: newaccepted

comment:3 Changed 6 months ago by rl1987

Status: acceptedneeds_review

comment:4 Changed 6 months ago by rl1987

Not sure about double-quoting EXTRA_CARGO_OPTIONS here - perhaps we do want to split it by space?

comment:5 Changed 6 months ago by nickm

I think splitting it is right -- if there are spaces there, we probably mean to pass multiple options to cargo.

comment:6 Changed 6 months ago by nickm

Milestone: Tor: 0.4.1.x-final

comment:7 Changed 5 months ago by dgoulet

Reviewer: catalyst

comment:8 Changed 5 months ago by catalyst

Status: needs_reviewmerge_ready

Looks good by visual inspection. I'll trust the CI on this one.

comment:9 Changed 5 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged to master!

Note: See TracTickets for help on using tickets.