Opened 7 months ago

Closed 6 months ago

#29065 closed defect (implemented)

shellcheck: test_switch_id.sh issues

Reported by: rl1987 Owned by: rl1987
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt
Cc: Actual Points:
Parent ID: Points:
Reviewer: mikeperry Sponsor:

Description

In test_switch_id.sh line 3:
if test "`id -u`" != '0'; then
         ^-- SC2006: Use $(..) instead of legacy `..`.


In test_switch_id.sh line 8:
if test "`id -u nobody`" = ""; then
         ^-- SC2006: Use $(..) instead of legacy `..`.

Child Tickets

Change History (9)

comment:1 Changed 7 months ago by rl1987

Owner: set to rl1987
Status: newaccepted

comment:2 Changed 7 months ago by rl1987

Status: acceptedneeds_review

comment:3 Changed 7 months ago by nickm

Milestone: Tor: 0.4.1.x-final

comment:4 Changed 6 months ago by dgoulet

Reviewer: mikeperry

comment:5 Changed 6 months ago by mikeperry

Status: needs_reviewneeds_revision

You're missing a $ in the if test "(id -u)" != '0'; then line.

comment:6 Changed 6 months ago by rl1987

Fixed inff5ced42ac4188b14be5d98ccf02ae174592a224.

Version 0, edited 6 months ago by rl1987 (next)

comment:7 Changed 6 months ago by rl1987

Status: needs_revisionneeds_review

comment:8 Changed 6 months ago by mikeperry

Status: needs_reviewmerge_ready

Looks good now.

comment:9 Changed 6 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Squashed and merged!

Note: See TracTickets for help on using tickets.