Opened 8 months ago

Closed 7 months ago

#29067 closed defect (fixed)

shellcheck: test_workqueue_*.sh issue

Reported by: rl1987 Owned by: rl1987
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt
Cc: Actual Points:
Parent ID: Points:
Reviewer: ahf Sponsor:

Description (last modified by rl1987)

In test_workqueue_efd.sh line 3:
${builddir:-.}/src/test/test_workqueue \
^-- SC2086: Double quote to prevent globbing and word splitting.

Also applies to test_workqueue_efd2.sh, test_workqueue_pipe.sh, test_workqueue_pipe2.sh and test_workqueue_socketpair.sh.

Child Tickets

Change History (8)

comment:1 Changed 8 months ago by rl1987

Description: modified (diff)
Summary: shellcheck: test_workqueue_efd.sh issueshellcheck: test_workqueue_*.sh issue

comment:2 Changed 8 months ago by rl1987

Owner: set to rl1987
Status: newaccepted

comment:3 Changed 8 months ago by rl1987

Status: acceptedneeds_review

comment:4 Changed 7 months ago by dgoulet

Reviewer: teor

comment:5 Changed 7 months ago by dgoulet

Reviewer: teorahf

(Mistake while assigning. These should go to ahf as a Reviewer.)

comment:6 Changed 7 months ago by ahf

Status: needs_reviewmerge_ready

Looks good to me.

comment:7 Changed 7 months ago by nickm

Milestone: Tor: 0.4.1.x-final

comment:8 Changed 7 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged to master (which is now 0.4.1)

Note: See TracTickets for help on using tickets.