Opened 6 weeks ago

Last modified 19 hours ago

#29069 merge_ready defect

shellcheck: autogen.sh issues

Reported by: rl1987 Owned by: rl1987
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description

In autogen.sh line 3:
if [ -x "`which autoreconf 2>/dev/null`" ] ; then
         ^-- SC2006: Use $(..) instead of legacy `..`.
          ^-- SC2230: which is non-standard. Use builtin 'command -v' instead.


In autogen.sh line 6:
  for i in $@; do
           ^-- SC2068: Double quote array expansions to avoid re-splitting elements.


In autogen.sh line 14:
  exec autoreconf $opt
                  ^-- SC2086: Double quote to prevent globbing and word splitting.

Child Tickets

Change History (4)

comment:1 Changed 5 weeks ago by rl1987

Owner: set to rl1987
Status: newaccepted

comment:2 Changed 5 weeks ago by rl1987

Status: acceptedneeds_review

comment:3 Changed 5 weeks ago by nickm

Milestone: Tor: 0.4.1.x-final
Status: needs_reviewmerge_ready

lgtm, let's take it in 0.4.1.x

comment:4 Changed 19 hours ago by nickm

Reviewer: nickm
Note: See TracTickets for help on using tickets.