#29072 closed defect (fixed)

shellcheck: check-tor issues

Reported by: rl1987 Owned by: rl1987
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

In check-tor line 36:
	echo ">>" wget --proxy=off -O - http://$ipop/tor/
                                               ^-- SC2086: Double quote to prevent globbing and word splitting.


In check-tor line 37:
	timeout 5 wget --proxy=off -O - http://$ipop/tor/ | head -n3
                                               ^-- SC2086: Double quote to prevent globbing and word splitting.


In check-tor line 41:
echo -n "$router "; echo "$lines" | grep 'fingerprint' | sed -e 's/^opt //' -e 's/^fingerprint //';
     ^-- SC2039: In POSIX sh, echo flags are undefined.

Child Tickets

Change History (8)

comment:1 Changed 20 months ago by rl1987

Owner: set to rl1987
Status: newaccepted

comment:2 Changed 20 months ago by rl1987

Status: acceptedneeds_review

https://github.com/torproject/tor/pull/672/files

As a side note, the directory server address on line 13 is obsolete. This script has been added in aa8321331f9ceeff647e9fe285e820f23c6ee039 back in 2005 and has not been updated ever since. Perhaps we should remove it from the repo?

comment:3 Changed 20 months ago by nickm

Milestone: Tor: 0.4.1.x-final

comment:4 Changed 20 months ago by dgoulet

Reviewer: dgoulet

comment:5 Changed 20 months ago by dgoulet

Status: needs_reviewneeds_revision

Yeah... this script is just totally obsolete and the dirserver seems to not exists at the moment. I think this can just have a git rm there...

comment:6 Changed 20 months ago by rl1987

Status: needs_revisionneeds_review

comment:7 Changed 20 months ago by dgoulet

Status: needs_reviewmerge_ready

Thanks! Ack!

comment:8 Changed 20 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged to master.

Note: See TracTickets for help on using tickets.