Opened 5 weeks ago

Closed 3 weeks ago

#29079 closed defect (implemented)

Minor bandwidth file spec updates

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-bwauth, torspec, doc, 041-proposed
Cc: Actual Points: 0.2
Parent ID: Points: 0.2
Reviewer: juga Sponsor:

Description (last modified by teor)

The terminator was 4 characters long from sbws 0.1.0 to sbws 1.0.0

https://gitweb.torproject.org/torspec.git/tree/bandwidth-file-spec.txt#n96

Child Tickets

Change History (11)

comment:1 Changed 5 weeks ago by teor

I'll do a bunch of minor changes in this ticket, in separate commits,

comment:2 Changed 5 weeks ago by teor

Description: modified (diff)
Status: assignedneeds_review
Summary: The terminator was 4 characters long from sbws 0.1.0 to sbws 1.0.0Minor bandwidth file spec updates

comment:3 Changed 5 weeks ago by asn

Reviewer: juga

comment:4 Changed 4 weeks ago by nickm

Keywords: postfreeze-ok added

Mark some tickets as postfreeze-ok, to indicate that I think they are okay to accept in 0.4.0 post-freeze. Does not indicate that they are all necessary to do postfreeze.

comment:5 Changed 4 weeks ago by juga

Status: needs_reviewneeds_revision

Looks good, i think there's a typo and i added a comment about the order of the headers.

comment:6 Changed 4 weeks ago by teor

Actual Points: 0.2
Keywords: 041-proposed added; postfreeze-ok removed
Milestone: Tor: 0.4.0.x-finalTor: 0.4.1.x-final
Points: 0.2
Status: needs_revisionneeds_review

The typo was in the previous version.

I added a commit to fix the order.

comment:7 in reply to:  6 Changed 3 weeks ago by juga

Status: needs_reviewmerge_ready

Replying to teor:

The typo was in the previous version.

ah, you're right, sorry.

I added a commit to fix the order.

LGTM. Though you might realize still more things to improve ;)

comment:8 Changed 3 weeks ago by atagar

Parent ID: #29056

Unparenting so I can close the other ticket.

comment:9 Changed 3 weeks ago by teor

Status: merge_readyneeds_review

One more fix: make it clear that Tor looks for a 5-character terminator.

I could have opened a separate ticket, but there would have been conflicts.

comment:10 Changed 3 weeks ago by juga

Status: needs_reviewmerge_ready

LGTM.

Forgot to comment that i was using 76 characters per line cause that is what i saw in older specs, but we don't have documentation about it, so i guess there's no restriction.

comment:11 Changed 3 weeks ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.