https-everywhere make.sh explicitly depends on missing python 3.6

The current deps list in https-everywhere's config lists python and python-lxml, but the 3.7 versions are installed. Fixed by explicitly requesting python3.6 and python3.6-lxml.

added TorBrowserTeam201901R component::applications/tor browser owner::boklm priority::very high resolution::fixed severity::normal status::closed type::defect labels

tor-browser-build: https://gitweb.torproject.org/user/richard/tor-browser-build.git/commit/?h=bug_29097&id=c4a48d79fb18f99d2737692a85b65d5faddc4e2e

Trac:
Status: assigned to needs_review

Trac:
Keywords: N/A deleted, TorBrowserTeam201901R added

What is the error that you get?

Is it because the python3 package in buster was previously installing python 3.6, but now they changed it to 3.7?

I wonder why python3.6 is actually hard-coded as this seems error-prone.

Trac:
Cc: tbb-team to tbb-team, legind

https://github.com/EFForg/https-everywhere/blob/master/utils/zipfile_deterministic.py, which ensures that Firefox builds are deterministic, is derived from the Python 3.6 standard library. We've targeted 3.6 for this reason, as well as to enforce similar tooling across different contributor development environments.

Trac:
Cc: tbb-team, legind to tbb-team, legind, alexishan

Replying to boklm:

What is the error that you get?

Is it because the python3 package in buster was previously installing python 3.6, but now they changed it to 3.7?

Yep that's exactly the issue.

Looks good to me. Cherry-picked to master (commit a1ac92687ed03f64c12992d7b83b40892beacb37) and maint-8.0 (commit 57a48c1c712a17bb2d58e3688d183bddd5e82423). Pinning the build script to a specific Python version seems a bit brittle to me but at least the HTTPS-Everywhere devs know about it now. :)

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

When building the container for https-everywhere, I now have the following error:

E: Unable to locate package python3.6-lxml
E: Couldn't find any package by glob 'python3.6-lxml'
E: Couldn't find any package by regex 'python3.6-lxml'

It seems the python3.6-lxml package does not exist anymore: https://packages.debian.org/search?keywords=python3.6-lxml

Trac:
Resolution: fixed to N/A
Status: closed to reopened

Can we build https-e without that package?

Trac:
Priority: Medium to Very High
Keywords: TorBrowserTeam201901R deleted, TorBrowserTeam201901 added

Replying to gk:

Can we build https-e without that package?

Yes, the build is working without that package.

There is a patch for review in branch bug_29097: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_29097&id=64ef8a5de677aac8b3b608ca8997363130690a6e

Trac:
Keywords: TorBrowserTeam201901 deleted, TorBrowserTeam201901R added
Status: reopened to needs_review

Looks good. Applied to master (commit 64ef8a5de677aac8b3b608ca8997363130690a6e) and maint-8.0 (commit 771bcf9f7dcec6ca17cc1f117891d538b8189ffe).

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#29097 (closed)