Opened 5 months ago

Closed 5 months ago

#29097 closed defect (fixed)

https-everywhere make.sh explicitly depends on missing python 3.6

Reported by: pospeselr Owned by: boklm
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201901R
Cc: tbb-team, legind, alexishan Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The current deps list in https-everywhere's config lists python and python-lxml, but the 3.7 versions are installed. Fixed by explicitly requesting python3.6 and python3.6-lxml.

Child Tickets

Change History (13)

comment:2 Changed 5 months ago by pospeselr

Keywords: TorBrowserTeam201901R added

comment:3 Changed 5 months ago by boklm

What is the error that you get?

Is it because the python3 package in buster was previously installing python 3.6, but now they changed it to 3.7?

comment:4 Changed 5 months ago by gk

Cc: legind added

I wonder why python3.6 is actually hard-coded as this seems error-prone.

comment:5 Changed 5 months ago by legind

https://github.com/EFForg/https-everywhere/blob/master/utils/zipfile_deterministic.py, which ensures that Firefox builds are deterministic, is derived from the Python 3.6 standard library. We've targeted 3.6 for this reason, as well as to enforce similar tooling across different contributor development environments.

comment:6 Changed 5 months ago by legind

Cc: alexishan added

comment:7 in reply to:  3 Changed 5 months ago by pospeselr

Replying to boklm:

What is the error that you get?

Is it because the python3 package in buster was previously installing python 3.6, but now they changed it to 3.7?

Yep that's exactly the issue.

comment:8 Changed 5 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. Cherry-picked to master (commit a1ac92687ed03f64c12992d7b83b40892beacb37) and maint-8.0 (commit 57a48c1c712a17bb2d58e3688d183bddd5e82423). Pinning the build script to a specific Python version seems a bit brittle to me but at least the HTTPS-Everywhere devs know about it now. :)

comment:9 Changed 5 months ago by boklm

Resolution: fixed
Status: closedreopened

When building the container for https-everywhere, I now have the following error:

E: Unable to locate package python3.6-lxml
E: Couldn't find any package by glob 'python3.6-lxml'
E: Couldn't find any package by regex 'python3.6-lxml'

It seems the python3.6-lxml package does not exist anymore:
https://packages.debian.org/search?keywords=python3.6-lxml

comment:10 Changed 5 months ago by gk

Can we build https-e without that package?

comment:11 Changed 5 months ago by gk

Keywords: TorBrowserTeam201901 added; TorBrowserTeam201901R removed
Priority: MediumVery High

comment:12 in reply to:  10 Changed 5 months ago by boklm

Keywords: TorBrowserTeam201901R added; TorBrowserTeam201901 removed
Status: reopenedneeds_review

Replying to gk:

Can we build https-e without that package?

Yes, the build is working without that package.

There is a patch for review in branch bug_29097:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_29097&id=64ef8a5de677aac8b3b608ca8997363130690a6e

comment:13 Changed 5 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Applied to master (commit 64ef8a5de677aac8b3b608ca8997363130690a6e) and maint-8.0 (commit 771bcf9f7dcec6ca17cc1f117891d538b8189ffe).

Note: See TracTickets for help on using tickets.