Opened 6 months ago

Last modified 13 days ago

#29100 merge_ready enhancement

Update src/app/config/fallback_dirs.inc to ../tor/src/app/config/fallback_dirs.inc post-split

Reported by: teor Owned by:
Priority: Medium Milestone:
Component: Core Tor/Fallback Scripts Version:
Severity: Normal Keywords: fallback
Cc: Actual Points: 2
Parent ID: #28793 Points: 1
Reviewer: nickm Sponsor:

Description

There are a bunch of references to src/app/config/fallback_dirs.inc for check_existing mode, and in the comments.

We should update them to ../tor/src/app/config/fallback_dirs.inc post-split.

Child Tickets

TicketTypeStatusOwnerSummary
#21282enhancementclosedAdjust fallback log levels
#28986defectclosedLog at info level in list generation mode
#30947defectclosedteorAdd a source line to the header, because type must always be fallback
#30948defectclosedteorCopy the relevant parts of .gitignore to fallback-scripts

Change History (11)

comment:1 Changed 6 months ago by teor

Milestone: Tor: 0.4.0.x-final

After #27914, fallback-scripts is its own repository. Fallback changes are no longer tied to Tor releases.

comment:2 Changed 6 months ago by teor

Keywords: 035-can postfreeze-ok removed

comment:3 Changed 6 weeks ago by teor

Parent ID: #27914#28793

Flatten ticket tree

comment:4 Changed 3 weeks ago by teor

Cc: asn dgoulet added; teor removed

See my pull request, which has changes for #29100, #30947, and #30948:
https://github.com/torproject/fallback-scripts/pull/2

asn, dgoulet, please assign this ticket to someone for review!

comment:5 Changed 3 weeks ago by teor

Status: newneeds_review

Oops

comment:6 Changed 3 weeks ago by teor

Cc: asn dgoulet removed
Reviewer: nickm

nickm is happy to review these changes.

comment:7 Changed 3 weeks ago by nickm

Status: needs_reviewneeds_revision

Looks good! I've added a small comment -- please feel free to adjust or merge at your discretion.

comment:8 in reply to:  7 Changed 3 weeks ago by teor

Status: needs_revisionneeds_review

Replying to nickm:

Looks good! I've added a small comment -- please feel free to adjust or merge at your discretion.

Thanks, I made most of the script variables configurable via env vars.

comment:9 Changed 3 weeks ago by teor

And added a few useful config options for testing / CI.

comment:10 Changed 3 weeks ago by teor

Actual Points: 2
Points: 1

comment:11 Changed 13 days ago by nickm

Status: needs_reviewmerge_ready

This looks good to me.

As a followup, I suggest changing the definition of getvar_conf() so that on error, it gives a more useful explaining what the problem is, and changing the definition of opt() so that it turns the empty string and/or a missing option into None, but reports errors otherwise.

That isn't super-urgent, though, since these scripts are only run by developers.

Note: See TracTickets for help on using tickets.