#29105 closed defect (fixed)

obfs4 compilation is busted starting with the nightly build from 01/17/2019

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201901R, GeorgKoppen201901
Cc: yawning, boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Commit 70d0e90c861be34ce3c5425ef1366a0b2ceb3026 breaks our nightly builds it seems:

Starting build: Thu Jan 17 01:58:24 2019
obfs4proxy.go:45:2: cannot find package "gitlab.com/yawning/obfs4.git/common/log" in any of:
	/var/tmp/dist/go/src/gitlab.com/yawning/obfs4.git/common/log (from $GOROOT)
	/var/tmp/dist/gopath/src/gitlab.com/yawning/obfs4.git/common/log (from $GOPATH)
obfs4proxy.go:46:2: cannot find package "gitlab.com/yawning/obfs4.git/common/socks5" in any of:
	/var/tmp/dist/go/src/gitlab.com/yawning/obfs4.git/common/socks5 (from $GOROOT)
	/var/tmp/dist/gopath/src/gitlab.com/yawning/obfs4.git/common/socks5 (from $GOPATH)
obfs4proxy.go:47:2: cannot find package "gitlab.com/yawning/obfs4.git/transports" in any of:
	/var/tmp/dist/go/src/gitlab.com/yawning/obfs4.git/transports (from $GOROOT)
	/var/tmp/dist/gopath/src/gitlab.com/yawning/obfs4.git/transports (from $GOPATH)
obfs4proxy.go:48:2: cannot find package "gitlab.com/yawning/obfs4.git/transports/base" in any of:
	/var/tmp/dist/go/src/gitlab.com/yawning/obfs4.git/transports/base (from $GOROOT)
	/var/tmp/dist/gopath/src/gitlab.com/yawning/obfs4.git/transports/base (from $GOPATH)
Starting build: Thu Jan 17 02:00:21 2019
obfs4proxy.go:45:2: cannot find package "gitlab.com/yawning/obfs4.git/common/log" in any of:
	/var/tmp/dist/go/src/gitlab.com/yawning/obfs4.git/common/log (from $GOROOT)
	/var/tmp/dist/gopath/src/gitlab.com/yawning/obfs4.git/common/log (from $GOPATH)
obfs4proxy.go:46:2: cannot find package "gitlab.com/yawning/obfs4.git/common/socks5" in any of:
	/var/tmp/dist/go/src/gitlab.com/yawning/obfs4.git/common/socks5 (from $GOROOT)
	/var/tmp/dist/gopath/src/gitlab.com/yawning/obfs4.git/common/socks5 (from $GOPATH)
obfs4proxy.go:47:2: cannot find package "gitlab.com/yawning/obfs4.git/transports" in any of:
	/var/tmp/dist/go/src/gitlab.com/yawning/obfs4.git/transports (from $GOROOT)
	/var/tmp/dist/gopath/src/gitlab.com/yawning/obfs4.git/transports (from $GOPATH)
obfs4proxy.go:48:2: cannot find package "gitlab.com/yawning/obfs4.git/transports/base" in any of:
	/var/tmp/dist/go/src/gitlab.com/yawning/obfs4.git/transports/base (from $GOROOT)
	/var/tmp/dist/gopath/src/gitlab.com/yawning/obfs4.git/transports/base (from $GOPATH)

Child Tickets

Change History (5)

comment:1 Changed 11 months ago by gk

Yawning, what's the plan here? Moving away from tpo infrastructure for obfs4?

comment:2 Changed 11 months ago by yawning

Yawning, what's the plan here? Moving away from tpo infrastructure for obfs4?

I vaguely feel like poking at the code again (no promises, no comment as to what I feel inspired to do), and life for me is easier using a hosted service.

Like mentioned in the commit, I'll keep pushing to both github.com and git.tp.o for the foreseeable future as a matter of courtesy, but the codebase now has a new canonical upstream.

comment:3 Changed 11 months ago by yawning

Sorry for the inconvenience, and I totally spaced on giving a heads up about it.

Since the build still uses $GOPATH, putting the source code in the correct location (something like $GOPATH/src/gitlab.com/yawning/obfs4.git) should be sufficient to fix things.

comment:4 in reply to:  3 ; Changed 11 months ago by gk

Keywords: TorBrowserTeam201901R GeorgKoppen201901 added
Status: newneeds_review

Replying to yawning:

Sorry for the inconvenience, and I totally spaced on giving a heads up about it.

It's fine. If you at some point don't push to the tpo repo anymore, a heads up would be appreciated.

Since the build still uses $GOPATH, putting the source code in the correct location (something like $GOPATH/src/gitlab.com/yawning/obfs4.git) should be sufficient to fix things.

Thanks. I did that in bug_29105 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_29105&id=aabf423be17388db2c980be9f04239479bdb6bb4) in my public tor-browser-build repo.

comment:5 in reply to:  4 Changed 11 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

Replying to gk:

Thanks. I did that in bug_29105 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_29105&id=aabf423be17388db2c980be9f04239479bdb6bb4) in my public tor-browser-build repo.

This looks good to me. This is now commit aabf423be17388db2c980be9f04239479bdb6bb4 on master.

Note: See TracTickets for help on using tickets.