Refactor crypto_digest.c to have fewer ifdefs

Our current crypto_digest.c is a maze of twisty little ifdefs, and OpenSSL keccak support in #28837 (moved) will make it even more so. We ought to refactor it so that it's less idiosyncratic.

Possibly we should take the same approach as in the other crypto_ops modules, and divide it into an OpenSSL portion, a NSS portion, and a common portion.

changed milestone to %Tor: 0.4.1.x-final

added 041-proposed asn-merge component::core tor/tor milestone::Tor: 0.4.1.x-final nickm-merge owner::rl1987 points::1 priority::medium refactor resolution::implemented reviewer::catalyst severity::normal sponsor::31-can status::closed technical-debt type::enhancement labels

Trac:
Owner: N/A to rl1987
Status: new to accepted

https://github.com/torproject/tor/pull/657

I could try unifying this patch with #28837 (moved), if that's needed.

Trac:
Status: accepted to needs_review

Trac:
Reviewer: N/A to catalyst

Replying to rl1987:

https://github.com/torproject/tor/pull/657

I could try unifying this patch with #28837 (moved), if that's needed. Thanks, if you could please resolve the current merge conflict, that would be great! Feel free to force-push the pull request branch this time.

Trac:
Status: needs_review to needs_revision

https://github.com/torproject/tor/pull/752

Trac:
Status: needs_revision to needs_review

Replying to rl1987:

https://github.com/torproject/tor/pull/752 This had a stochastic test failure so I restarted that Travis job and will try to look at it if that passes.

Replying to rl1987:

https://github.com/torproject/tor/pull/752 Thanks! This looks good. I did manual builds with NSS and OpenSSL.

Trac:
Status: needs_review to merge_ready

This is a refactor, so it belongs in master. (We also have NSS in our Travis CI, and it passed.)

Trac:
Keywords: N/A deleted, nickm-merge, asn-merge, teor-merge added
Type: task to enhancement
Milestone: Tor: unspecified to Tor: 0.4.1.x-final

batch-modify: asn has offered to merge these tomorrow, so removing them from teor's plate. Teor -- you can merge these anyway if you are blocked on any of them and it would save you time to do so.

Trac:
Keywords: 041-proposed refactor technical-debt, teor-merge deleted, 041-proposed, technical-debt, refactor added

color-move makes the double-checking pretty nice here. Merged to master!

Trac:
Resolution: N/A to implemented
Status: merge_ready to closed

closed

changed time estimate to 8h

moved to tpo/core/tor#29108 (closed)