Opened 4 weeks ago

Last modified 4 weeks ago

#29108 needs_review task

Refactor crypto_digest.c to have fewer ifdefs

Reported by: nickm Owned by: rl1987
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 041-proposed refactor technical-debt
Cc: Actual Points:
Parent ID: Points: 1
Reviewer: catalyst Sponsor: Sponsor31-can

Description

Our current crypto_digest.c is a maze of twisty little ifdefs, and OpenSSL keccak support in #28837 will make it even more so. We ought to refactor it so that it's less idiosyncratic.

Possibly we should take the same approach as in the other crypto_ops modules, and divide it into an OpenSSL portion, a NSS portion, and a common portion.

Child Tickets

Change History (3)

comment:1 Changed 4 weeks ago by rl1987

Owner: set to rl1987
Status: newaccepted

comment:2 Changed 4 weeks ago by rl1987

Status: acceptedneeds_review

https://github.com/torproject/tor/pull/657

I could try unifying this patch with #28837, if that's needed.

comment:3 Changed 4 weeks ago by dgoulet

Reviewer: catalyst
Note: See TracTickets for help on using tickets.