Opened 4 months ago

Closed 4 months ago

#29135 closed defect (fixed)

Failing to connect to a v3 onion service with client auth produces really long lines in log

Reported by: pastly Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.3.5.7
Severity: Normal Keywords: tor-hs, 035-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

IMO Tor shouldn't log the entire descriptor a level warn.

Jan 19 16:22:54.692 [warn] Client authorization for requested onion address is invalid. Can't decrypt the descriptor.
Jan 19 16:22:54.692 [warn] Failed to parse received descriptor "hs-descriptor 3\ndescriptor-lifetime 180\ndescriptor-signing-key-cert\n-----BEGIN ED25519 CERT-----\nAQgABo/UAYFloHvVvnlNECHb5xleCJR [... it keeps going for about 4000 more characters ...]

Child Tickets

Change History (4)

comment:1 Changed 4 months ago by rl1987

Status: new → needs_review

​https://github.com/torproject/tor/pull/660

comment:2 Changed 4 months ago by nickm

Milestone: → Tor: 0.3.5.x-final

Is this a candidate for 0.3.5 backport? Guessing "yes".

comment:3 Changed 4 months ago by dgoulet

Keywords: tor-hs 035-backport added
Reviewer: → dgoulet
Status: needs_review → merge_ready

To help things out, here is the 035 branch with rl1987 commit cherry-picked (no changes): ticket29135_035_01.

comment:4 Changed 4 months ago by nickm

Resolution: → fixed
Status: merge_ready → closed

thanks; merged to 0.3.5 and forward!

Note: See TracTickets for help on using tickets.