Standardize 'Bandwidth File' name

Usually the 'Bandwidth File' spec called its actual documents 'Bandwidth Lists'. Juga and teor have both said they prefer the term 'Bandwidth File'. Standardizing this so we have a consistent name for these documents...

https://trac.torproject.org/projects/tor/ticket/28615#comment:9

Fix is available in the 'bandwidth_file_name' branch of my spec repo...

https://gitweb.torproject.org/user/atagar/torspec.git/commit/?h=bandwidth_file_name

changed milestone to %Tor: 0.4.1.x-final

added 041-proposed bwauth component::core tor/tor fast-fix milestone::Tor: 0.4.1.x-final points::0.1 priority::medium resolution::fixed reviewer::teor severity::normal status::closed type::defect labels

Trac:
Status: new to needs_review

Replying to atagar:

Fix is available in the 'bandwidth_file_name' branch of my spec repo...

https://gitweb.torproject.org/user/atagar/torspec.git/commit/?h=bandwidth_file_name

I think it's fine except for the last 2 lines changes. Maybe create a PR so that it can be reviewed by others?.

I suggest that we review this in 0.4.1, without discussing it at the team meeting.

Trac:
Keywords: N/A deleted, 041-proposed, fast-fix, bwauth added
Points: N/A to 0.1
Milestone: N/A to Tor: 0.4.1.x-final

Trac:
Reviewer: N/A to teor

Thanks for this pull request.

Sorry it's taken me a while to get to it, I was at a hackfest, then on leave.

Replying to juga:

Replying to atagar:

Fix is available in the 'bandwidth_file_name' branch of my spec repo...

https://gitweb.torproject.org/user/atagar/torspec.git/commit/?h=bandwidth_file_name

I think it's fine except for the last 2 lines changes. Maybe create a PR so that it can be reviewed by others?.

I opened a pull request at https://github.com/torproject/torspec/pull/57

There are 3 places where the search-and-replace is wrong. Would you mind reverting them?

Since you made your branch, the file has been updated, so there are merge conflicts. Would you mind rebasing your changes on master?

Trac:
Status: needs_review to needs_revision

This fix conflicts with #29578 (moved).

Replying to teor:

This fix conflicts with #29578 (moved).

#29578 (moved) has been merged, please rebase when you revise.

Rebased my bandwidth_file_name branch and dealt with the conflicts.

https://gitweb.torproject.org/user/atagar/torspec.git/commit/?h=bandwidth_file_name

Trac:
Status: needs_revision to merge_ready

I can merge once Teor acks.

Trac:
Status: merge_ready to needs_review

One of the changes I requested was not in the updated pull request. That's probably a GitHub UI issue, because the lines were also changed in the rebase.

A added a fixup commit to make the change I requested.

I also added two other commits: one fixes an incorrect description, and the other removes some trailing spaces.

I'm happy for nickm to check my changes, apply the fixup to atagar's commit, then merge.

Trac:
Status: needs_review to merge_ready

Squashed & merged

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

Hi Nick, reopening because I'm not seeing this commit in the repo.

Merge request is for: https://gitweb.torproject.org/user/atagar/torspec.git/commit/?h=bandwidth_file_name

But not seeing it in: https://gitweb.torproject.org/torspec.git/log/

Trac:
Status: closed to reopened
Resolution: fixed to N/A

Replying to atagar:

Hi Nick, reopening because I'm not seeing this commit in the repo.

Merge request is for: https://gitweb.torproject.org/user/atagar/torspec.git/commit/?h=bandwidth_file_name

My extra changes are in https://github.com/torproject/torspec/pull/57 , so let's make sure we merge that.

But not seeing it in: https://gitweb.torproject.org/torspec.git/log/

I don't see a merge either. Maybe Nick didn't push?

Trac:
Status: reopened to merge_ready

You're correct, I did forget to push. Better now?

Yup. Thanks Nick.

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

changed time estimate to 48m

mentioned in issue #29578 (moved)

moved to tpo/core/tor#29137 (closed)