Opened 3 months ago

Closed 3 months ago

#29143 closed defect (fixed)

Building obfs4 in tor-browser-build nightlies is broken due to uTLS support

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201901R
Cc: boklm, yawning Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Starting build: Mon Jan 21 13:50:13 2019
/var/tmp/dist/gopath/src/gitlab.com/yawning/obfs4.git/transports/meeklite/transport.go:30:2: cannot find package "github.com/refraction-networking/utls" in any of:
	/var/tmp/dist/go/src/github.com/refraction-networking/utls (from $GOROOT)
	/var/tmp/dist/gopath/src/github.com/refraction-networking/utls (from $GOPATH)
/var/tmp/dist/gopath/src/golang.org/x/net/idna/idna.go:23:2: cannot find package "golang.org/x/text/secure/bidirule" in any of:
	/var/tmp/dist/go/src/golang.org/x/text/secure/bidirule (from $GOROOT)
	/var/tmp/dist/gopath/src/golang.org/x/text/secure/bidirule (from $GOPATH)
/var/tmp/dist/gopath/src/golang.org/x/net/idna/idna.go:24:2: cannot find package "golang.org/x/text/unicode/bidi" in any of:
	/var/tmp/dist/go/src/golang.org/x/text/unicode/bidi (from $GOROOT)
	/var/tmp/dist/gopath/src/golang.org/x/text/unicode/bidi (from $GOPATH)
/var/tmp/dist/gopath/src/golang.org/x/net/idna/idna.go:25:2: cannot find package "golang.org/x/text/unicode/norm" in any of:
	/var/tmp/dist/go/src/golang.org/x/text/unicode/norm (from $GOROOT)
	/var/tmp/dist/gopath/src/golang.org/x/text/unicode/norm (from $GOPATH)

Child Tickets

Change History (9)

comment:1 Changed 3 months ago by boklm

(the nightly build from today did not fail because it was started before the obfs4 commit was pushed)

comment:2 Changed 3 months ago by yawning

Well, yeah. There's more dependencies, and some of the existing ones may need to be bumped. Eventually all the meek components are going to start requiring some of these as well.

        git.torproject.org/pluggable-transports/goptlib.git v0.0.0-20190117054722-15f83653abbc
        github.com/agl/ed25519 v0.0.0-20170116200512-5312a6153412
        github.com/dchest/siphash v1.2.1
        github.com/refraction-networking/utls v0.0.0-20190105024908-a89e7e6da482
        golang.org/x/crypto v0.0.0-20190103213133-ff983b9c42bc
        golang.org/x/net v0.0.0-20190119204137-ed066c81e75e
        golang.org/x/sys v0.0.0-20190116161447-11f53e031339 // indirect
        golang.org/x/text v0.3.0 // indirect

Note: Depending on how much goes into utls, the version required to build the eventual tagged release may differ.

comment:3 Changed 3 months ago by dcf

From #29077 I have a patch for packaging utls and dependencies:
https://gitweb.torproject.org/user/dcf/tor-browser-build.git/commit/?h=meek-client-utls&id=283a587d76cd800279751ca66589bcfeea433bd5

Edit: I don't know what's going on with the golang.org/x/text dependency. For whatever reason, I didn't need to package that one.

Last edited 3 months ago by dcf (previous) (diff)

comment:5 in reply to:  3 Changed 3 months ago by yawning

Replying to dcf:

Edit: I don't know what's going on with the golang.org/x/text dependency. For whatever reason, I didn't need to package that one.

arnhem :: Documents/Development/obfs4 ‹master*› % go mod why -m golang.org/x/text 
# golang.org/x/text
gitlab.com/yawning/obfs4.git/transports/meeklite
golang.org/x/net/http2
golang.org/x/net/idna
golang.org/x/text/secure/bidirule

comment:6 Changed 3 months ago by boklm

In branch bug_29143_v3 I use var/go_lib_deps instead of some tar commands in var/build_go_lib_pre (after being reminded about it by dcf's patch):
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_29143_v3&id=ef3e30c73afef06081f11778a29bbfb6a101644d

This patch is fixing the build for me, however I did not check yet that it is running correctly.

I also see dcf's patch is adding golang.org/x/crypto/chacha20poly1305 and golang.org/x/crypto/cryptobyte to go_lib_install in projects/goxcrypto/config.

comment:7 Changed 3 months ago by boklm

Keywords: TorBrowserTeam201901R added; TorBrowserTeam201901 removed
Status: newneeds_review

There is a new revision of the patch, for review, in branch bug_29143_v5:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_29143_v5&id=2b4d602d729c448c4f7246eb8220f4f0614f77a5

I checked that it is running correctly on Linux, in the alpha and nightly builds.

comment:9 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good now. Thanks for the work while being busy with all the other important stuff, boklm! Merged to master (commit f27f11201d86b8bb909bad8b4c04f841b5487ddb).

Note: See TracTickets for help on using tickets.