Opened 11 months ago

Closed 10 months ago

Last modified 9 months ago

#29161 closed defect (fixed)

Expect some gmtime/localtime() failures on windows, don't log bugs from tests.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt, postfreeze-ok
Cc: Actual Points:
Parent ID: Points:
Reviewer: ahf Sponsor:

Description


Child Tickets

Change History (6)

comment:1 Changed 11 months ago by nickm

Status: assignedneeds_review

6144cf99adae5f in the parent branch has the fix for this.

comment:2 Changed 10 months ago by dgoulet

Reviewer: teor

comment:3 Changed 10 months ago by dgoulet

Reviewer: teorahf

(Mistake while assigning. These should go to ahf as a Reviewer.)

comment:4 Changed 10 months ago by ahf

Status: needs_reviewmerge_ready

The patch in https://github.com/torproject/tor/pull/650/commits/6144cf99adae5ffebbc549a4e0f3c6e05e51ad16 looks good to me.

Looks like asn marked the parent merge_ready too, so marking this one merge_ready as well even though it will get in with the parent.

comment:5 Changed 10 months ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

Merged as part of parent.

comment:6 Changed 9 months ago by teor

Keywords: 035-backport removed
Parent ID: #28668

No backport tags in children, no parents when modifying closed tickets.

Note: See TracTickets for help on using tickets.