Opened 9 months ago

Closed 9 months ago

#29169 closed defect (fixed)

32-bit warnings in test_circuitpadding.c

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points: .1
Parent ID: Points: .1
Reviewer: Sponsor: Sponsor2

Description

Ugh, Jenkins is failing. Time to fix it. Here's an example:

16:52:06 src/test/test_circuitpadding.c:1864:43: error: implicit conversion loses integer precision: 'circpad_time_t' (aka 'unsigned long long') to 'long' [-Werror,-Wshorten-64-to-32]
16:52:06   tt_int_op(client_side->padding_info[0]->padding_scheduled_at_usec,
16:52:06   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~

Child Tickets

Change History (4)

comment:1 Changed 9 months ago by nickm

Actual Points: .1
Status: assignedmerge_ready

https://github.com/torproject/tor/pull/668 is my PR for bug29169. I'll merge this if travis passes, since the change is trivial.

comment:2 Changed 9 months ago by nickm

Sponsor: Sponsor2

comment:3 Changed 9 months ago by nickm

Merged. Let's see if Jenkins is happier now.

comment:4 Changed 9 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

This warning does appear to be fixed.

Note: See TracTickets for help on using tickets.