#29178 closed defect (fixed)

Don't build master of goxcrypto, goxnet, uniuri and go-webrtc

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201901R, tbb-rbm
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

During the review of #29143 we discussed in which cases a component in nightly builds should use the master commit. The conclusion was that we usually want to use master for the things we develop, but not for external components.

goxcrypto, goxnet, uniuri are external components that are currently built using master. go-webrtc is not but has a master target that looks like if it was named master instead of nightly as an error.

Child Tickets

Change History (2)

comment:1 Changed 10 months ago by boklm

Keywords: TorBrowserTeam201901R added; TorBrowserTeam201901 removed
Status: newneeds_review

comment:2 Changed 10 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Merged to master (commit 5bad67e4f31d984702c530cbd423d83d009e699a).

Note: See TracTickets for help on using tickets.