Opened 6 months ago

Closed 6 months ago

#29183 closed defect (fixed)

We are using linux i686 langpacks in the linux x86_64 builds

Reported by: langpack Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201902R, tbb-rbm
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Building project firefox-langpacks - firefox-langpacks-60.5.0esr-build2-windows-x86_64-05346c
File SHA512SUMS-60.5.0esr-build2 is signed with id 14F26682D0916CDD81E37B6D61B7B526D98F0353
Using file /home/tbb-nightly/tbb-testsuite/clones/tor-browser-build/out/firefox-langpacks/SHA512SUMS-60.5.0esr-build2
--2019-01-26 06:47:02-- https://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/60.5.0esr-candidates/build2/win64/xpi/ar.xpi

Building project firefox-langpacks - firefox-langpacks-60.5.0esr-build2-windows-i686-5b2f52
File SHA512SUMS-60.5.0esr-build2 is signed with id 14F26682D0916CDD81E37B6D61B7B526D98F0353
Using file /home/tbb-nightly/tbb-testsuite/clones/tor-browser-build/out/firefox-langpacks/SHA512SUMS-60.5.0esr-build2
--2019-01-26 05:28:39-- https://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/60.5.0esr-candidates/build2/win32/xpi/ar.xpi

but

Building project firefox-langpacks - firefox-langpacks-60.5.0esr-build2-linux-x86_64-cee57d
File SHA512SUMS-60.5.0esr-build2 is signed with id 14F26682D0916CDD81E37B6D61B7B526D98F0353
Using file /home/tbb-nightly/tbb-testsuite/clones/tor-browser-build/out/firefox-langpacks/SHA512SUMS-60.5.0esr-build2
--2019-01-26 02:49:23-- https://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/60.5.0esr-candidates/build2/linux-i686/xpi/ar.xpi
i686 here!

Building project firefox-langpacks - firefox-langpacks-60.5.0esr-build2-linux-i686-cee57d
File SHA512SUMS-60.5.0esr-build2 is signed with id 14F26682D0916CDD81E37B6D61B7B526D98F0353
Using file /home/tbb-nightly/tbb-testsuite/clones/tor-browser-build/out/firefox-langpacks/SHA512SUMS-60.5.0esr-build2
Using directory /home/tbb-nightly/tbb-testsuite/clones/tor-browser-build/out/firefox-langpacks/dl-langpack-linux-i686-60.5.0esr-build2
Build log: /home/tbb-nightly/tbb-testsuite/tor-browser-builds/2019-01-26/nightly-linux-i686/logs/firefox-langpacks-linux-i686.log
Finished build of project firefox-langpacks - firefox-langpacks-60.5.0esr-build2-linux-i686-cee57d
No downloads at all!

Child Tickets

Change History (4)

comment:1 Changed 6 months ago by boklm

Summary: TBB Nightlies langpacksWe are using linux i686 langpacks in the linux x86_64 builds

Yes, var/ff_arch is the same for linux32 and linux64 builds:
https://gitweb.torproject.org/builders/tor-browser-build.git/tree/projects/firefox-langpacks/config

So we are using i686 langpacks in the x86_64 builds. We were doing that to in tor-browser-bundle.git too:
https://gitweb.torproject.org/builders/tor-browser-bundle.git/commit/?id=9cfe20990de219540d29378e8dacc24130a80ce3

I don't know if there was a reason to do that. But we can easily change it if that's better.

comment:2 Changed 6 months ago by gk

I don't remember either. So, yes, let's change it to avoid confusion.

comment:3 Changed 6 months ago by boklm

Keywords: TorBrowserTeam201902R tbb-rbm added
Status: newneeds_review

comment:4 Changed 6 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Merged to master (commit 86ebdafc28a55042fea553ad7f23f796ea963b75).

Note: See TracTickets for help on using tickets.