Bump NSIS version to 3.04

A new NSIS version is out, 3.04 and we should switch to that one for creating our Windows installers.

added GeorgKoppen201901 TorBrowserTeam201909R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-rbm type::defect labels

bug_29187 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_29187&id=8c79a97d86183c3d69f97a72338e5b515c1649d4) in my public repo has the fix. However, we should figure out what is going on in #29185 (moved) first in order to be sure 3.04 is not introducing new reproducibility issues.

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201901 deleted, TorBrowserTeam201901R added

no-insert-timestamp.patch?

Trac:
Username: langpack

Moving our review tickets to February.

Trac:
Keywords: TorBrowserTeam201901R deleted, TorBrowserTeam201902R added

February is gone.

Trac:
Keywords: TorBrowserTeam201902R deleted, TorBrowserTeam201903R added

Moving review tickets to April.

Trac:
Keywords: TorBrowserTeam201903R deleted, TorBrowserTeam201904R added

No April anymore, moving review tickets to May.

Trac:
Keywords: TorBrowserTeam201904R deleted, TorBrowserTeam201905R added

Moving reviews over to June.

Trac:
Keywords: TorBrowserTeam201905R deleted, TorBrowserTeam201906R added

No reviews in June 2019 anymore, moving them.

Trac:
Keywords: TorBrowserTeam201906R deleted, TorBrowserTeam201907R added

No July any longer.

Trac:
Keywords: TorBrowserTeam201907R deleted, TorBrowserTeam201908R added

No August anymore.

Trac:
Keywords: TorBrowserTeam201908R deleted, TorBrowserTeam201909R added

Replying to gk:

bug_29187 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_29187&id=8c79a97d86183c3d69f97a72338e5b515c1649d4) in my public repo has the fix. However, we should figure out what is going on in #29185 (moved) first in order to be sure 3.04 is not introducing new reproducibility issues.

I started two builds on two machines with this patch on top of master, to check if the build is still reproducible with this version of NSIS.

Replying to boklm:

Replying to gk:

bug_29187 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_29187&id=8c79a97d86183c3d69f97a72338e5b515c1649d4) in my public repo has the fix. However, we should figure out what is going on in #29185 (moved) first in order to be sure 3.04 is not introducing new reproducibility issues.

I started two builds on two machines with this patch on top of master, to check if the build is still reproducible with this version of NSIS.

In a first test I had matching i686 builds, but non matching x86_64, but it was probably caused by using different commits as the builds were not started exactly at the same time. On a second test, I now have x86_64 matching builds too. So this looks good to me.

I cherry-picked the patch as commit 936f5d7ad170e4d0dddc141906f006a6273196c8 on master.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#29187 (closed)