Opened 8 months ago

Closed 7 months ago

#29194 closed defect (fixed)

Set DEBIAN_FRONTEND=noninteractive when installing packages

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/rbm Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201903R
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The build of the buster container image used for building https-everywhere is getting stuck because a configuration windows for setting up the tango-common package is waiting for input.

Child Tickets

Change History (8)

comment:1 Changed 8 months ago by boklm

As buster is still changing a lot, causing some breakages, maybe we could think about building our own python 3.6 on a stable Debian release instead of using buster.

comment:2 Changed 8 months ago by boklm

Component: Applications/Tor BrowserApplications/rbm
Owner: changed from tbb-team to boklm
Summary: Build of buster container for https-everywhere is getting stuckSet DEBIAN_FRONTEND=noninteractive when installing packages

It seems using the -y argument with apt-get install is enough to remove all configuration prompts, but not all of them. We should add the DEBIAN_FRONTEND=noninteractive environment variable, and maybe the -q argument.

comment:3 Changed 8 months ago by boklm

Cc: tbb-team added

comment:4 Changed 7 months ago by boklm

In branch bug_29194 I made a patch setting DEBIAN_FRONTEND=noninteractive. However, I didn't fully test it yet, and because it is changing build instructions for all containers, it will require everything to be rebuilt.

With #29235 we stopped using buster in projects/https-everywhere, however we still use in in projects/tor-browser for android-armv7. Before merging the fix that will require rebuilding everything, I think we could start by fixing it only for projects/tor-browser on android-armv7:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_29194_android&id=c87154eadb5920aa54e52763fd092dea56e97485

And later merge the full fix, after more testing.

comment:5 in reply to:  4 Changed 7 months ago by gk

Status: newneeds_information

Replying to boklm:

In branch bug_29194 I made a patch setting DEBIAN_FRONTEND=noninteractive. However, I didn't fully test it yet, and because it is changing build instructions for all containers, it will require everything to be rebuilt.

With #29235 we stopped using buster in projects/https-everywhere, however we still use in in projects/tor-browser for android-armv7. Before merging the fix that will require rebuilding everything, I think we could start by fixing it only for projects/tor-browser on android-armv7:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_29194_android&id=c87154eadb5920aa54e52763fd092dea56e97485

And later merge the full fix, after more testing.

What's the plan here? Bite the bullet and merge the full fix for getting everything rebuilt and tested before 8.5 gets stable? Or anything else?

comment:6 Changed 7 months ago by boklm

Keywords: TorBrowserTeam201902R added; TorBrowserTeam201901 removed
Status: needs_informationneeds_review

comment:7 Changed 7 months ago by gk

Keywords: TorBrowserTeam201903R added; TorBrowserTeam201902R removed

February is gone.

comment:8 Changed 7 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. Merged to rbm's master (commit c61e6940a1824462648064898be0759dd1600414) and tor-browser-build's master (commit 799ccf053e78b385fbd2900e092113849d73c94b).

Note: See TracTickets for help on using tickets.