Opened 7 months ago

Closed 11 days ago

#29197 closed defect (fixed)

remove use of overlays from Tor Launcher

Reported by: mcs Owned by: brade
Priority: Medium Milestone:
Component: Applications/Tor Launcher Version:
Severity: Normal Keywords: ff68-esr, ux-team, tbb-9.0-must-nightly, TorBrowserTeam201908R
Cc: tbb-team, antonela, acat Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor44-can

Description

XUL overlay support was removed from Firefox beginning with Firefox 63. See https://bugzilla.mozilla.org/show_bug.cgi?id=1449791

Tor Launcher uses an overlay to allow configuration UI elements to be shared between the setup wizard and the Tor Network Settings dialog. We will need to replace this with a preprocessor #include strategy or just maintain two copies of the XUL.

Child Tickets

Change History (11)

comment:1 Changed 7 months ago by mcs

Keywords: ff68-esr added

comment:2 Changed 3 months ago by pili

Cc: antonela added
Keywords: ux-team added

This will need some ux team work

comment:3 in reply to:  2 ; Changed 3 months ago by mcs

Replying to pili:

This will need some ux team work

As far as I know, our plan is to not make any functional or UX changes. XUL overlays are just a fancy #include like mechanism for UI layout. The removal of XUL overlays is a "behind the scenes" task that should not affect anything visible to our users.

comment:4 in reply to:  3 Changed 3 months ago by gk

Replying to mcs:

Replying to pili:

This will need some ux team work

As far as I know, our plan is to not make any functional or UX changes. XUL overlays are just a fancy #include like mechanism for UI layout. The removal of XUL overlays is a "behind the scenes" task that should not affect anything visible to our users.

Yes, I think the UX work would come into play, however, if we make progress on our plan in #10760 of moving the relevant parts of Torbutton directly into browser code and getting rid of the items behind the onion button (by moving the ones we want to keep somewhere else) and the onion button itself.

comment:5 Changed 4 weeks ago by gk

Keywords: TorBrowserTeam201907 tbb-9.0-must-nightly added

comment:6 Changed 3 weeks ago by mcs

Keywords: TorBrowserTeam201907R added; TorBrowserTeam201907 removed
Status: newneeds_review

We ended up using the window.MozXULElement.parseXULToFragment() function that Mozilla added since ESR60, which allows for "overlay-like" functionality. Please review, and note that these changes are not backwards compatible with pre-ESR68 code.

https://gitweb.torproject.org/user/brade/tor-launcher.git/commit/?h=bug29197-01&id=8bc4a8869936cfc782d1f4c749f7608ead6ddf18

Also note that to have a good experience with an ESR68-based Tor Browser you will want our patch from #31300 too.

comment:7 Changed 3 weeks ago by gk

Cc: acat added

acat: could you review the patch?

comment:8 Changed 2 weeks ago by gk

Keywords: TorBrowserTeam201908R added; TorBrowserTeam201907R removed

No July any longer.

comment:9 Changed 2 weeks ago by acat

Looks good to me, also tested it and it works fine.

I find the number of lines changed surprisingly low considering it's changing a *.xul file to a *.js :)

comment:10 Changed 2 weeks ago by pili

Sponsor: Sponsor44-can

Adding Sponsor 44 to ESR68 tickets

comment:11 Changed 11 days ago by gk

Resolution: fixed
Status: needs_reviewclosed

Merged to master (commit 8bc4a8869936cfc782d1f4c749f7608ead6ddf18).

Note: See TracTickets for help on using tickets.