Opened 5 months ago

Last modified 7 weeks ago

#29197 new defect

remove use of overlays from Tor Launcher

Reported by: mcs Owned by: brade
Priority: Medium Milestone:
Component: Applications/Tor Launcher Version:
Severity: Normal Keywords: ff68-esr, ux-team
Cc: tbb-team, antonela Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

XUL overlay support was removed from Firefox beginning with Firefox 63. See https://bugzilla.mozilla.org/show_bug.cgi?id=1449791

Tor Launcher uses an overlay to allow configuration UI elements to be shared between the setup wizard and the Tor Network Settings dialog. We will need to replace this with a preprocessor #include strategy or just maintain two copies of the XUL.

Child Tickets

Change History (4)

comment:1 Changed 5 months ago by mcs

Keywords: ff68-esr added

comment:2 Changed 7 weeks ago by pili

Cc: antonela added
Keywords: ux-team added

This will need some ux team work

comment:3 in reply to:  2 ; Changed 7 weeks ago by mcs

Replying to pili:

This will need some ux team work

As far as I know, our plan is to not make any functional or UX changes. XUL overlays are just a fancy #include like mechanism for UI layout. The removal of XUL overlays is a "behind the scenes" task that should not affect anything visible to our users.

comment:4 in reply to:  3 Changed 7 weeks ago by gk

Replying to mcs:

Replying to pili:

This will need some ux team work

As far as I know, our plan is to not make any functional or UX changes. XUL overlays are just a fancy #include like mechanism for UI layout. The removal of XUL overlays is a "behind the scenes" task that should not affect anything visible to our users.

Yes, I think the UX work would come into play, however, if we make progress on our plan in #10760 of moving the relevant parts of Torbutton directly into browser code and getting rid of the items behind the onion button (by moving the ones we want to keep somewhere else) and the onion button itself.

Note: See TracTickets for help on using tickets.