remove use of overlays from Tor Launcher

XUL overlay support was removed from Firefox beginning with Firefox 63. See https://bugzilla.mozilla.org/show_bug.cgi?id=1449791

Tor Launcher uses an overlay to allow configuration UI elements to be shared between the setup wizard and the Tor Network Settings dialog. We will need to replace this with a preprocessor #include strategy or just maintain two copies of the XUL.

added TorBrowserTeam201908R component::applications/tor launcher ff68-esr owner::brade priority::medium resolution::fixed severity::normal sponsor::44-can status::closed tbb-9.0-must-nightly type::defect ux-team labels

Trac:
Keywords: N/A deleted, ff68-esr added

This will need some ux team work

Trac:
Keywords: N/A deleted, ux-team added
Cc: tbb-team to tbb-team, antonela

Replying to pili:

This will need some ux team work

As far as I know, our plan is to not make any functional or UX changes. XUL overlays are just a fancy #include like mechanism for UI layout. The removal of XUL overlays is a "behind the scenes" task that should not affect anything visible to our users.

Replying to mcs:

Replying to pili:

This will need some ux team work

As far as I know, our plan is to not make any functional or UX changes. XUL overlays are just a fancy #include like mechanism for UI layout. The removal of XUL overlays is a "behind the scenes" task that should not affect anything visible to our users.

Yes, I think the UX work would come into play, however, if we make progress on our plan in #10760 (moved) of moving the relevant parts of Torbutton directly into browser code and getting rid of the items behind the onion button (by moving the ones we want to keep somewhere else) and the onion button itself.

Trac:
Keywords: N/A deleted, tbb-9.0-must-nightly, TorBrowserTeam201907 added

We ended up using the window.MozXULElement.parseXULToFragment() function that Mozilla added since ESR60, which allows for "overlay-like" functionality. Please review, and note that these changes are not backwards compatible with pre-ESR68 code.

https://gitweb.torproject.org/user/brade/tor-launcher.git/commit/?h=bug29197-01&id=8bc4a8869936cfc782d1f4c749f7608ead6ddf18

Also note that to have a good experience with an ESR68-based Tor Browser you will want our patch from #31300 (moved) too.

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201907 deleted, TorBrowserTeam201907R added

acat: could you review the patch?

Trac:
Cc: tbb-team, antonela to tbb-team, antonela, acat

No July any longer.

Trac:
Keywords: TorBrowserTeam201907R deleted, TorBrowserTeam201908R added

Looks good to me, also tested it and it works fine.

I find the number of lines changed surprisingly low considering it's changing a *.xul file to a *.js :)

Adding Sponsor 44 to ESR68 tickets

Trac:
Sponsor: N/A to Sponsor44-can

Merged to master (commit 8bc4a8869936cfc782d1f4c749f7608ead6ddf18).

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #30429 (moved)

mentioned in issue #31286 (moved)

mentioned in issue #31300 (moved)

moved to tpo/applications/tor-launcher#29197 (closed)

mentioned in issue tpo/applications/tor-launcher#31300 (closed)