Opened 19 months ago

Closed 2 months ago

#29217 closed enhancement (worksforme)

Script to add new tor files and modules in rust and/or C

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 043-deferred
Cc: nickm Actual Points:
Parent ID: Points: 2
Reviewer: Sponsor:


This should support modules that are subsystems and/or optional.

Child Tickets

#31335defectclosedteormake check-includes does not check out of tree builds correctly
#31336defectclosedFix usage for

Change History (12)

comment:1 Changed 16 months ago by nickm

Milestone: Tor: 0.4.2.x-final

Tentatively placing some roadmapped tasks for s31 into 0.4.2.

comment:2 Changed 15 months ago by nickm

Partial implementation here in my branch add_c_file, which I am currently using. :)

comment:3 Changed 13 months ago by gaba

Cc: nickm added
Keywords: network-team-roadmap-september added

comment:4 Changed 13 months ago by teor

Nick, it looks like was added in commit 2f31c8146f in

But it has a bug: the suggested usage fails with:

$ scripts/maint/ ./src/feature/dirauth/ocelot.c
Made files successfully but couldn't identify for ./src/feature/dirauth/ocelot.c
Exit 1

The correct usage has no "./":

$ scripts/maint/ src/feature/dirauth/ocelot.c

We should fix the usage, or make topdir_file() use python's canonical path functions.

comment:5 Changed 13 months ago by nickm

Right; is only a partial implementation of this feature. We also need a way to add new modules, a way to add headers only, a way to add rust modules, and more.

comment:6 Changed 12 months ago by teor

I opened #31335 and #31336 for bugs that we need to fix when we implement this ticket.

comment:7 Changed 11 months ago by nickm

Type: defectenhancement

Mark a number of current 0.4.2.x "defects" as "enhancements."

comment:8 Changed 11 months ago by nickm

Milestone: Tor: 0.4.2.x-finalTor: 0.4.3.x-final

Defer several enhancements from "new" to 0.4.3.

comment:9 Changed 7 months ago by gaba

Keywords: network-team-roadmap-september removed
Sponsor: Sponsor31-can

Sponsor closed. Remove from roadmap.

comment:10 Changed 7 months ago by nickm

Keywords: 043-deferred added

All 0.4.3.x tickets without 043-must, 043-should, or 043-can are about to be deferred.

comment:11 Changed 7 months ago by nickm

Milestone: Tor: 0.4.3.x-finalTor: 0.4.4.x-final

comment:12 Changed 2 months ago by nickm

Resolution: worksforme
Status: newclosed

We have add_c_file, and we can add a rust version of it once we're seriously working on Rust again.

Note: See TracTickets for help on using tickets.