Opened 21 months ago

Last modified 5 months ago

#29220 assigned task

Update review guidelines to list best practices

Reported by: nickm Owned by: asn
Priority: Medium Milestone: Tor: 0.4.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: doc, 042-deferred, s31-docs, 045-should
Cc: Actual Points:
Parent ID: Points: 2
Reviewer: Sponsor:

Description

When we come up with some target guidelines in #29219 , we should make sure that our coding standards document them.

Child Tickets

Change History (18)

comment:1 Changed 19 months ago by nickm

Milestone: Tor: 0.4.1.x-final

comment:2 Changed 18 months ago by nickm

Keywords: doc added

Mark a few documentation tickets as "doc"

comment:3 Changed 18 months ago by nickm

Milestone: Tor: 0.4.1.x-finalTor: 0.4.2.x-final

Move various s31 refactoring tasks to 0.4.2

comment:4 Changed 17 months ago by gaba

Keywords: network-team-roadmap-2019-Q1Q2 added

comment:5 Changed 17 months ago by catalyst

Owner: set to catalyst
Status: newassigned

comment:6 Changed 17 months ago by gaba

Owner: catalyst deleted

comment:7 Changed 14 months ago by nickm

Mark some assigned tickets as 042-should.

comment:8 Changed 14 months ago by nickm

Keywords: 042-should added

comment:9 Changed 14 months ago by nickm

Keywords: s31-docs added

comment:10 Changed 13 months ago by ahf

Owner: set to asn

Distributing 0.4.2 tickets between network team members.

comment:11 Changed 13 months ago by asn

I think #29219 is a prerequisite for this ticket, but #29219 has not been completed. Hence I suggest we push this to 043, given the lack of #29219 and also its non-urgency.

comment:12 Changed 13 months ago by asn

Keywords: 042-deferred added; 042-should removed
Milestone: Tor: 0.4.2.x-finalTor: 0.4.3.x-final

Moving to 043 after discussion in meeting.

comment:13 Changed 10 months ago by ahf

Keywords: 043-should added

comment:14 Changed 9 months ago by gaba

Sponsor: Sponsor31-can

Sponsor closed. Remove from roadmap.

comment:15 Changed 9 months ago by gaba

Keywords: network-team-roadmap-2019-Q1Q2 removed

comment:16 Changed 7 months ago by asn

Milestone: Tor: 0.4.3.x-finalTor: 0.4.4.x-final

comment:17 Changed 7 months ago by teor

Keywords: 044-should added; 043-should removed

This ticket is in 0.4.4, so it can't be 043-should.

Last edited 7 months ago by teor (previous) (diff)

comment:18 Changed 5 months ago by nickm

Keywords: 045-should added; 044-should removed
Milestone: Tor: 0.4.4.x-finalTor: 0.4.5.x-final
Note: See TracTickets for help on using tickets.