Opened 10 months ago

Last modified 2 months ago

#29220 assigned task

Update review guidelines to list best practices

Reported by: nickm Owned by: asn
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: doc, network-team-roadmap-2019-Q1Q2, 042-deferred, s31-docs
Cc: Actual Points:
Parent ID: Points: 2
Reviewer: Sponsor: Sponsor31-can

Description

When we come up with some target guidelines in #29219 , we should make sure that our coding standards document them.

Child Tickets

Change History (12)

comment:1 Changed 8 months ago by nickm

Milestone: Tor: 0.4.1.x-final

comment:2 Changed 7 months ago by nickm

Keywords: doc added

Mark a few documentation tickets as "doc"

comment:3 Changed 7 months ago by nickm

Milestone: Tor: 0.4.1.x-finalTor: 0.4.2.x-final

Move various s31 refactoring tasks to 0.4.2

comment:4 Changed 7 months ago by gaba

Keywords: network-team-roadmap-2019-Q1Q2 added

comment:5 Changed 6 months ago by catalyst

Owner: set to catalyst
Status: newassigned

comment:6 Changed 6 months ago by gaba

Owner: catalyst deleted

comment:7 Changed 3 months ago by nickm

Mark some assigned tickets as 042-should.

comment:8 Changed 3 months ago by nickm

Keywords: 042-should added

comment:9 Changed 3 months ago by nickm

Keywords: s31-docs added

comment:10 Changed 2 months ago by ahf

Owner: set to asn

Distributing 0.4.2 tickets between network team members.

comment:11 Changed 2 months ago by asn

I think #29219 is a prerequisite for this ticket, but #29219 has not been completed. Hence I suggest we push this to 043, given the lack of #29219 and also its non-urgency.

comment:12 Changed 2 months ago by asn

Keywords: 042-deferred added; 042-should removed
Milestone: Tor: 0.4.2.x-finalTor: 0.4.3.x-final

Moving to 043 after discussion in meeting.

Note: See TracTickets for help on using tickets.