Opened 16 months ago

Last modified 3 months ago

#29226 new task

Automate application of C formatting to code

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: network-team-roadmap-2020Q1, 042-deferred-20190918, 043-deferred
Cc: nickm, catalyst Actual Points:
Parent ID: Points: 5
Reviewer: Sponsor:

Description

We have never applied a C formatter to our code. Doing so will hurt -- once. After that we might be much happier. We have the opportunity to

This has the potential to be a major bikeshed point, though: we should try to come up with a set of standards that all the active developers can tolerate, and a mainstream well-supported tool can support.

Child Tickets

TicketStatusOwnerSummaryComponent
#31177closednickmStart conversation about auto-formatting our C codeCore Tor/Tor
#31713newAutomatically run the autostyle scripts before every commitCore Tor/Tor
#32522assignedCreate better tooling for canonical tor header includesCore Tor/Tor
#32764closednickmSolve code issues that block running clang-format on our code.Core Tor/Tor
#32921closednickmCode and script changes to run clang-format without breaking checkSpaces or coccinelleCore Tor/Tor

Change History (10)

comment:1 Changed 16 months ago by rl1987

See also: #27713

comment:2 Changed 14 months ago by nickm

Milestone: Tor: 0.4.2.x-final

Tentatively placing some roadmapped tasks for s31 into 0.4.2.

comment:3 Changed 11 months ago by gaba

Cc: nickm taylor added
Keywords: network-team-roadmap-october added

comment:4 Changed 10 months ago by arma

Cc: catalyst added; taylor removed

comment:5 Changed 9 months ago by nickm

Keywords: 042-deferred-20190918 added
Milestone: Tor: 0.4.2.x-finalTor: 0.4.3.x-final

Defer numerous 0.4.2 tickets to 0.4.3.

comment:6 Changed 5 months ago by gaba

Keywords: network-team-roadmap-2020Q1 added; network-team-roadmap-october removed

comment:7 Changed 4 months ago by gaba

Sponsor: Sponsor31-can

Sponsor closed. Remove from roadmap.

comment:8 Changed 4 months ago by nickm

Keywords: 043-deferred added

All 0.4.3.x tickets without 043-must, 043-should, or 043-can are about to be deferred.

comment:9 Changed 4 months ago by nickm

Milestone: Tor: 0.4.3.x-finalTor: 0.4.4.x-final

comment:10 Changed 3 months ago by nickm

https://github.com/barisione/clang-format-hooks/ seems like it has ideas worth adapting here.

Note: See TracTickets for help on using tickets.