Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#29235 closed defect (fixed)

Build of https-everywhere fails because python3.6 is not available in buster anymore

Reported by: boklm Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201901R, tbb-rbm
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Running apt-get install python3.6 in buster now results in python 3.7 being installed.

I think we can fix that by building our own version of python 3.6 on Debian stable.

Child Tickets

Change History (6)

comment:1 Changed 10 months ago by boklm

Keywords: TorBrowserTeam201901R added; TorBrowserTeam201901 removed
Status: newneeds_review

comment:2 Changed 10 months ago by pospeselr

This patch looks good to me. Apt version 1.4.9 is the first version with the redirect vulnerability fixed right?

comment:3 Changed 10 months ago by gk

Keywords: TorBrowserTeam201901 added; TorBrowserTeam201901R removed
Status: needs_reviewneeds_revision

Just some nits:

s/we add the the common-stretch/we add the common-stretch/

You have

+distdir=/var/tmp/dist/python

while we have in numerous other projects something like

distdir=/var/tmp/dist/[% project %]

. Which pattern should we use?

s/common-strech target/common-stretch target/

comment:4 in reply to:  3 Changed 10 months ago by boklm

Keywords: TorBrowserTeam201901R added; TorBrowserTeam201901 removed
Status: needs_revisionneeds_review

comment:5 Changed 10 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Fixed with commit 66a0ab022c3c539a3756771cf72e793fa2e861e7 on master (I fixed s/ourself/ourselves/ in the commit message myself to avoid another roundtrip).

comment:6 Changed 10 months ago by gk

Applied to maint-8.0 (commit d036a293dcd041d3ed4d02453b85aa03cfed23fa).

Note: See TracTickets for help on using tickets.