Opened 8 months ago

Closed 6 months ago

#29243 closed defect (fixed)

Fix minor bugs in the HSv3 unit tests

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.3.2.1-alpha
Severity: Normal Keywords: prop224, tor-hs, single-onion, ipv6, 034-triage-20180328, 034-removed-20180328, fast-fix, 040-unreached-20190109, 041-proposed
Cc: neel@… Actual Points: 0.1
Parent ID: #23576 Points: 0.1
Reviewer: Sponsor:

Description

The tests:

  • copy the first 20 characters of a 40-character hex string to a binary fingerprint
  • put IPv6 addresses in a variable called "ipv4"
  • do a duplicate tt_int_op() to deliberately fail and print a value, without a comment explaining the code

Let's review these changes in #23576.

Child Tickets

Change History (2)

comment:1 Changed 7 months ago by teor

Status: assignedneeds_revision

comment:2 Changed 6 months ago by teor

Resolution: fixed
Status: needs_revisionclosed
Note: See TracTickets for help on using tickets.