Opened 4 months ago

Last modified 5 weeks ago

#29294 needs_revision defect

Create an script to automate releases

Reported by: juga Owned by: juga
Priority: Medium Milestone: sbws: unspecified
Component: Core Tor/sbws Version: sbws: 1.0.2
Severity: Normal Keywords: easy, 10-proposed, network-team-roadmap-2019-Q1Q2, no-changes-version, sbws-11x-final-removed-20190312, reviewer-was-teor-20190422
Cc: juga Actual Points: 1
Parent ID: #29953 Points: 1
Reviewer: Sponsor:

Description


Child Tickets

Change History (24)

comment:1 Changed 4 months ago by juga

Milestone: sbws: 1.1.x-finalsbws: 1.0.x-final

Moved to 1.0 milestone so that it can be used to actually release 1.0.3.

comment:2 Changed 4 months ago by juga

Points: 0.2

comment:3 Changed 4 months ago by juga

Owner: set to juga
Points: 0.21
Status: newassigned

Minimum points is 1. Assign to myself.

comment:4 Changed 4 months ago by juga

Keywords: easy added
Status: assignedneeds_review

https://github.com/torproject/sbws/pull/332
Putting into needs_review, though this doesn't affect the functionality of the scanner. I'll merge it in any case if it's not reviewed in 1 week.

comment:5 Changed 3 months ago by dgoulet

Reviewer: teor

comment:6 Changed 3 months ago by juga

Merged in a branch with current master and current needs_review tickets and tested a whole loop with the public Tor network

comment:7 Changed 3 months ago by teor

Status: needs_reviewneeds_revision

I did a quick review on the pull request.

comment:8 Changed 3 months ago by juga

Status: needs_revisionneeds_review

I replied to your question.
Regarding the changelog changes, if you have a graphical diff tool (like meld), you can compare the .rst and the .md, and see that the changes are only the format and the section [Unreleased].

comment:9 Changed 3 months ago by juga

Also created #29582.

comment:10 Changed 3 months ago by teor

Answering juga's question from IRC:

you prefer i rm the script and add doc, or just leave it like it is now?

It's up to you.

It is weird to have a script that just prints instructions.

It is good that the script shows the right versions in the instructions.
Can you add a comment explaining that the script shows the right versions?

Do you plan on modifying the script so it automates more tasks in future releases?
Can you add a comment explaining that the script will get better?

comment:11 Changed 3 months ago by teor

Status: needs_reviewneeds_revision

comment:12 Changed 3 months ago by juga

Keywords: 10-proposed added
Milestone: sbws: 1.0.x-finalsbws: 1.1.x-final

Moving to milestione 1.1 tickets which we don't know if they need to be implemented after 1.0.3 has been released or that can only be done after 1.0 has been released

comment:13 Changed 3 months ago by juga

Status: needs_revisionneeds_review

ok, now i made an actual script

comment:14 Changed 3 months ago by gaba

Keywords: network-team-roadmap-2019-Q1Q2 added

comment:15 Changed 3 months ago by teor

Status: needs_reviewneeds_revision

Seems good to me, but I think it needs a changes file?

(I don't need to review your changes file, because we have an automated script for that! So feel free to flip it into merge_ready when you're done.)

comment:16 in reply to:  15 ; Changed 3 months ago by juga

Actual Points: 1
Status: needs_revisionmerge_ready

Replying to teor:

Seems good to me, but I think it needs a changes file?

You mean a changelog?. There's the one in markdown.
I added an extra changelog file in .rst because i need to convert the .md one to .rst, but there's now in master a .rst one generated this way. The master doesn't have yet this script nor the templates.

(I don't need to review your changes file, because we have an automated script for that!

The changelog is semi-automated. I left one line per feature/bug and removed the extra commit lines.

So feel free to flip it into merge_ready when you're done.)

I'm going to assume that this is still ready to merge.

comment:17 in reply to:  16 Changed 3 months ago by teor

Replying to juga:

Replying to teor:

Seems good to me, but I think it needs a changes file?

Sorry, I put this comment on the wrong ticket.

I'm going to assume that this is still ready to merge.

I made some comments on the pull request. There are some changes that would make it easier for other people to use.

comment:18 Changed 3 months ago by teor

Status: merge_readyneeds_revision

comment:19 Changed 2 months ago by juga

Status: needs_revisionneeds_review

Made the changes you commented.

comment:20 Changed 2 months ago by teor

Status: needs_reviewneeds_revision

I left questions on the pull request about using GitHub's tarball.

comment:21 Changed 2 months ago by juga

Keywords: no-changes-version added

Add keyword to help planify releases/milestones.
Tickets that doesn't imply a change of version are tickets which do not affect the code (docs, tests) and some time of refactors.

comment:22 Changed 2 months ago by juga

Keywords: sbws-11x-final-removed-20190312 added
Milestone: sbws: 1.1.x-finalsbws: unspecified

Remove tickets from 11x-final that can be implemented next month

comment:23 Changed 8 weeks ago by juga

Parent ID: #29953

Assign parent to easy, no-changes-version tickets to better track them

comment:24 Changed 5 weeks ago by teor

Keywords: reviewer-was-teor-20190422 added
Reviewer: teor

If these tickets go back in to needs_review, and I am on leave, they will need another reviewer.

Note: See TracTickets for help on using tickets.