Opened 7 months ago

Closed 6 months ago

#29295 closed defect (fixed)

Remove three consecutive attempts to build a circuit

Reported by: juga Owned by: juga
Priority: Medium Milestone: sbws: 1.0.x-final
Component: Core Tor/sbws Version: sbws: 1.0.2
Severity: Normal Keywords: easy
Cc: juga Actual Points:
Parent ID: Points: 1
Reviewer: asn Sponsor:

Description (last modified by juga)

Currently, a relay is measured to when measuring a relay, circuits are attempted to be built a maximum of 3 consecutives times when the previous measurements fail attempt fails, but in most of the cases, when measuring a relay building a circuit fails the first time, it will also fail the consecutives times.
The relay will be measured anyway in the next iteration.

Based on what we talked in https://trac.torproject.org/projects/tor/wiki/org/meetings/2019BrusselsNetworkTeam/Notes/SBWSRoadmap#Questions

Edit: the three attempts happen when trying to build the circuit when measuring a relay, but it's not three attempts to measure the relay.

Child Tickets

Change History (10)

comment:1 Changed 7 months ago by juga

Milestone: sbws: unspecifiedsbws: 1.0.x-final

Moved to 1.0 milestone since it's very easy and will speed up the scanner

comment:2 Changed 7 months ago by juga

Points: 0.1

comment:3 Changed 7 months ago by juga

Description: modified (diff)
Summary: Remove three consecutive attempts to measure a relayRemove three consecutive attempts to build a circuit

comment:4 Changed 7 months ago by juga

Owner: set to juga
Points: 0.11
Status: newassigned

comment:5 Changed 7 months ago by juga

Status: assignedneeds_review

comment:6 Changed 6 months ago by juga

Keywords: easy added

The fix itself is only 1 line, the other commits refactor the code and add a test.

comment:7 Changed 6 months ago by dgoulet

Reviewer: asn

comment:8 Changed 6 months ago by asn

Patches looks good to me. BTW, what's the way to run the integration test added by the final commit?

comment:9 Changed 6 months ago by asn

Status: needs_reviewmerge_ready

OK integration tests pass fine with tox -e integration.

LGTM!

comment:10 Changed 6 months ago by juga

Resolution: fixed
Status: merge_readyclosed

Thanks, merged!

Note: See TracTickets for help on using tickets.