Opened 14 years ago

Last modified 7 years ago

#293 closed defect (Fixed)

RedirectExit option broken in tor-0.1.1.20 [patch included]

Reported by: olden Owned by:
Priority: Low Milestone:
Component: Core Tor/Tor Version: 0.1.1.18-rc
Severity: Keywords:
Cc: olden Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Using RedirectExit in torrc causes Tor 0.1.1.20 to exit, only leaving in the log:
set_options(): Acting on config options left us in a broken state. Dying.

Root cause afaik is missing braces in src/or/config.c

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (4)

comment:1 Changed 14 years ago by olden

[Can't create an attachment, so here's the patch as a comment]

* src/or/config.c_orig Tue May 23 00:05:58 2006
--- src/or/config.c Wed May 24 00:55:12 2006
*
* 726,736

{

smartlist_t *sl = smartlist_create();
char *errmsg = NULL;

! for (cl = options->RedirectExit; cl; cl = cl->next) {

if (parse_redirect_line(sl, cl, &errmsg)<0)

log_warn(LD_CONFIG, "%s", errmsg);
tor_free(errmsg);
return -1;

}
set_exit_redirects(sl);

}

--- 726,739 ----

{

smartlist_t *sl = smartlist_create();
char *errmsg = NULL;

! for (cl = options->RedirectExit; cl; cl = cl->next)
! {

if (parse_redirect_line(sl, cl, &errmsg)<0)

+ {

log_warn(LD_CONFIG, "%s", errmsg);
tor_free(errmsg);
return -1;

+ }

}
set_exit_redirects(sl);

}

comment:2 Changed 14 years ago by arma

You're right. I've fixed in cvs. It will be included in 0.1.1.21. Thanks!

comment:3 Changed 14 years ago by arma

flyspray2trac: bug closed.

comment:4 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.