Opened 9 months ago

Closed 9 months ago

#29325 closed defect (fixed)

Non-Android Tor Browser nightly builds are broken when compiling obfs4

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201902R
Cc: boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Starting build: Mon Feb  4 08:00:50 2019
/var/tmp/dist/gopath/src/gitlab.com/yawning/obfs4.git/transports/meeklite/meek.go:50:2: cannot find package "gitlab.com/yawning/utls.git" in any of:
	/var/tmp/dist/go/src/gitlab.com/yawning/utls.git (from $GOROOT)
	/var/tmp/dist/gopath/src/gitlab.com/yawning/utls.git (from $GOPATH)

Child Tickets

Change History (7)

comment:1 Changed 9 months ago by yawning

Using the tag, though I'm not sure when the next time I'll feel inspired to add features will be.

https://lists.torproject.org/pipermail/tor-dev/2019-February/013663.html

https://gitlab.com/yawning/utls/tags/v0.0.9-2

Note: My utls fork (but not upstream) depends on github.com/dsnet/compress.

comment:2 Changed 9 months ago by cypherpunks

Static PK Pinning is not HPKP.

comment:3 Changed 9 months ago by yawning

"HPKP style"

It's a pre-loaded pin list (2.7.), that searches for an intersection between the known pins and the cert chain(s) (2.6.), where pins are defined as a SPKI fingerprint using SHA256 (2.4.).

What does arguing over semantics contribute to fixing the build?

comment:4 Changed 9 months ago by cypherpunks

"HPKP style" was bad TOFU, deprecated, and even somewhere dead. "SPKP style" is not deprecated, has nothing related to HTTP and, thus, to "HPKP style".

comment:5 Changed 9 months ago by yawning

What does arguing over semantics contribute to fixing the build?

comment:6 Changed 9 months ago by boklm

Keywords: TorBrowserTeam201902R added; TorBrowserTeam201902 removed
Status: newneeds_review

comment:7 Changed 9 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good, thanks. Merged to master (commit 50193b4aff592e79b5a45fccb2a1547cef8e2691).

Note: See TracTickets for help on using tickets.