Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#29327 closed defect (fixed)

TypeError: hostName is null on about:tor page

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: GeorgKoppen201902, TorBrowserTeam201902R
Cc: pospeselr Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Load about:tor and open the Page Info dialog (with Ctrl + I). TypeError: hostName is null will show up in the browser console pointing to

var isOnion = hostName.endsWith(".onion");

Noticed on our blog: https://blog.torproject.org/comment/279506#comment-279506

Child Tickets

Change History (5)

comment:1 Changed 8 months ago by gk

Cc: pospeselr added
Keywords: GeorgKoppen201902 TorBrowserTeam201902R added
Status: newneeds_review

comment:2 Changed 8 months ago by mcs

r=brade, r=mcs
This looks good to us.

comment:3 Changed 8 months ago by cypherpunks

So, was it worth reporting or just a waste of time?

comment:4 in reply to:  3 ; Changed 8 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Replying to cypherpunks:

So, was it worth reporting or just a waste of time?

Yes, it was worth it, thanks. However, playing games like in #28238 *is* a waste of time, please stop it (I am pretty sure I don't ask for the first time for that kind of thing).

That said: this got merged to tor-browser-60.5.0esr-8.5-1 (commit 71eb1c774844d5662184914f4defd76110fe0ef7).

comment:5 in reply to:  4 Changed 8 months ago by gk

Replying to gk:

Replying to cypherpunks:

So, was it worth reporting or just a waste of time?

Yes, it was worth it, thanks. However, playing games like in #28238 *is* a waste of time, please stop it (I am pretty sure I don't ask for the first time for that kind of thing).

Oh, and this holds for blog comments, too. Thanks.

Note: See TracTickets for help on using tickets.