Opened 6 months ago

Closed 5 months ago

#29434 closed enhancement (implemented)

Consider removing linux-tor-prio.sh from contrib/operator-tools

Reported by: rl1987 Owned by:
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt, fast-fix, nickm-merge, asn-merge
Cc: mikeperry Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: juga, teor Sponsor:

Description

This script wasn't updated much since 2008 or so. Is it still used by anyone?

If not, we should delete it.

Child Tickets

TicketTypeStatusOwnerSummary
#29073defectclosedrl1987shellcheck: linux-tor-prio.sh issues

Change History (8)

comment:1 Changed 6 months ago by rl1987

TODO: email tor-relays@ about this.

comment:2 Changed 5 months ago by rl1987

Status: newneeds_review

I asked [0] and nobody replied. I think it's safe to remove it.

https://github.com/torproject/tor/pull/781

comment:3 Changed 5 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.4.1.x-final

comment:4 Changed 5 months ago by asn

Reviewer: juga

comment:5 in reply to:  2 ; Changed 5 months ago by juga

Status: needs_reviewneeds_revision

Replying to rl1987:

I asked [0] and nobody replied. I think it's safe to remove it.

i found the link [0]: https://lists.torproject.org/pipermail/tor-relays/2019-February/016995.html

In a fast search i found that someone was still using it in 2015 [1].
Just some questions:
Is it possible that some other application/device using Tor is using it?.
Any idea on how we could find out easy?.
Do you know if there's some other recommended way to achieve the same this script does?.
Should the script itself be removed from too?.

[1] https://lists.torproject.org/pipermail/tor-talk/2015-January/036455.html

comment:6 in reply to:  5 Changed 5 months ago by teor

Actual Points: 0.1
Keywords: technical-debt fast-fix nickm-merge asn-merge added
Points: 0.1
Reviewer: jugajuga, teor
Status: needs_revisionmerge_ready
Type: taskenhancement

I have reviewed this pull request, and I think we should remove this script.
(But now I can't merge it, because I have reviewed it.)

Here is why:

Replying to juga:

Replying to rl1987:

I asked [0] and nobody replied. I think it's safe to remove it.

i found the link [0]: https://lists.torproject.org/pipermail/tor-relays/2019-February/016995.html

In a fast search i found that someone was still using it in 2015 [1].

Our earliest supported release is 0.2.9, which was released in December 2016:
https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/CoreTorReleases#Current

So we don't support things that were only used back in 2015.

And we never fixed a bug in the script, where it confuses kilobits and kilobytes:
https://lists.torproject.org/pipermail/tor-talk/2015-January/036458.html

So the script has been unmaintained for at least 4 years.

Just some questions:
Is it possible that some other application/device using Tor is using it?.

If they are, they can keep a copy of the script, and maintain it themselves.

Any idea on how we could find out easy?.

Remove the script, document the removal in the release notes, and see if someone complains.

Do you know if there's some other recommended way to achieve the same this script does?.

BandwidthRate and BandwidthBurst are supported, cross-platform torrc options that limit Tor's bandwidth. They are integrated with the bandwidth weighting system.

I would not recommend using this script instead, because large changes in relay bandwidth are not a good experience for Tor users. (And they lead to inaccurate bandwidth weights on the network.)

Should the script itself be removed from too?.

This pull request removes the script from Tor's future releases.

comment:7 Changed 5 months ago by juga

teor, thanks for the detailed explanation

comment:8 Changed 5 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged to master.

Note: See TracTickets for help on using tickets.