Opened 8 months ago

Closed 7 months ago

#29436 closed defect (fixed)

Add scripts to test unit test coverage determinism

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points: 0
Parent ID: Points:
Reviewer: mikeperry Sponsor:

Description

Back in #25908 I wrote some scripts to check whether our test coverage was deterministic, but I never cleaned them up or checked them in. I should do that.

Child Tickets

Change History (5)

comment:1 Changed 8 months ago by nickm

Status: assignedneeds_review

I've made a branch ticket29436_040. It is based on my ticket29435_040 branch, which fixes the coverage script.

There's a PR at https://github.com/torproject/tor/pull/695 -- only the last two commits are new on this branch.

comment:2 Changed 7 months ago by dgoulet

Reviewer: mikeperry

comment:3 Changed 7 months ago by mikeperry

Status: needs_reviewmerge_ready

The goal here is just to output the diff files? The script looks like it does that just fine, so merge ready for that.. But what consumes this output? Should we have a different script that fails the test if the coverage diff is nonzero?

comment:4 Changed 7 months ago by nickm

This is meant to be human-consumed to find out where the nondeterminism is; I wouldn't mind another script to check determinism though.

comment:5 Changed 7 months ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

Merged in master. Thanks!

Note: See TracTickets for help on using tickets.