Opened 7 years ago

Closed 7 years ago

Last modified 4 months ago

#2950 closed defect (fixed)

Make Permissions-Manager memory-only in TorBrowser

Reported by: mikeperry Owned by: mikeperry
Priority: Medium Milestone:
Component: Firefox Patch Issues Version:
Severity: Blocker Keywords: MikePerryIteration20110515, tbb-no-uplift
Cc: lunar@…, erinn Actual Points: 3
Parent ID: #2877 Points: 2
Reviewer: Sponsor:

Description

By default, the new Firefox 4 permissions manager should be memory-only. This will also solve the STS problem, which stores its state in the permissions manager.

Child Tickets

Attachments (1)

memory-permissions.diff (2.5 KB) - added by mikeperry 7 years ago.
Diff against FF4.0.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by mikeperry

Component: Tor bundles/installationTor Browser
Owner: changed from erinn to mikeperry
Status: newaccepted

comment:2 Changed 7 years ago by lunar

Cc: lunar@… added

comment:3 Changed 7 years ago by mikeperry

For the permissions manager, it lives in extensions/cookie/nsPermissionManager.cpp. THe code that creates the database is in nsPermissionManager::InitDB().

It looks like we can hack it to be a memory only db according to: https://developer.mozilla.org/en/XPCOM_Interface_Reference/mozIStorageService#openSpecialDatabase%28%29

comment:4 Changed 7 years ago by mikeperry

Keywords: MikePerryIteration20110515 added
Points: 2

This is probably going to break stuff and require some extensive semi-extensive testing just to see if it is working right..

comment:5 Changed 7 years ago by mikeperry

Actual Points: 3
Resolution: fixed
Status: acceptedclosed

Alright! We've got a working pref 'permissions.memory_only' that causes the permissions DB to be memory-only if set, and I also added a pref observer for it, so that it may be toggled to clear the DB. This appears to work.

Changed 7 years ago by mikeperry

Attachment: memory-permissions.diff added

Diff against FF4.0.

comment:6 Changed 7 years ago by erinn

Cc: erinn added

comment:7 Changed 4 months ago by arthuredelstein

Keywords: tbb-no-uplift added
Severity: Blocker
Note: See TracTickets for help on using tickets.