Opened 5 months ago

Closed 4 months ago

#29530 closed defect (fixed)

Some address/get_if_addrs* tests fail when the network is unreachable

Reported by: teor Owned by: nickm
Priority: High Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.3.5.8
Severity: Normal Keywords: tor-test, regression, tor-ci, fast-fix 035-backport
Cc: Actual Points:
Parent ID: Points: 0.5
Reviewer: dgoulet Sponsor:

Description

I see these failures when my network connection is off:

address/get_if_addrs_list_internal: Feb 19 21:28:39.823 [err] connect() failed: 
Network is unreachable

  [get_if_addrs_list_internal FAILED]
address/get_if_addrs_list_no_internal: Feb 19 21:28:39.825 [err] connect() failed: Network is unreachable

  [get_if_addrs_list_no_internal FAILED]
address/get_if_addrs6_list_internal: OK
address/get_if_addrs6_list_no_internal: [forking] OK
address/get_if_addrs_internal_fail: OK
address/get_if_addrs_no_internal_fail: OK
address/get_if_addrs: Feb 19 21:28:39.881 [err] connect() failed: Network is unreachable

  [get_if_addrs FAILED]

The quick fix is to downgrade them to warnings.

Child Tickets

Change History (12)

comment:1 Changed 5 months ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 5 months ago by nickm

Priority: MediumHigh

comment:3 Changed 5 months ago by nickm

Status: acceptedneeds_review

Branch is ticket29530_040 with PR at https://github.com/torproject/tor/pull/713 . I haven't tested this on OSX with a disabled network yet.

comment:4 Changed 5 months ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready

lgtm;

comment:5 Changed 5 months ago by arma

Resolution: fixed
Status: merge_readyclosed

It is merged!

comment:6 Changed 5 months ago by bmwiedemann

Resolution: fixed
Status: closedreopened

This bug also affects 0.3.5.8 ; please backport.

When building packages for openSUSE, we do so without any network connectivity to ensure no external inputs are used in a build.
After the update of 0.3.5.7 to 0.3.5.8 this broke 3 tests.

comment:7 Changed 5 months ago by nickm

Keywords: 035-backport added

comment:8 Changed 5 months ago by nickm

Milestone: Tor: 0.4.0.x-finalTor: 0.3.5.x-final

comment:9 in reply to:  6 Changed 5 months ago by teor

Status: reopenedneeds_review
Version: Tor: unspecifiedTor: 0.3.5.8

Replying to bmwiedemann:

This bug also affects 0.3.5.8 ; please backport.

See my 0.3.5 backport in https://github.com/torproject/tor/pull/727

I cherry-picked nickm's commit, edited the commit message, and added a changes file.
It merged cleanly to master.

When building packages for openSUSE, we do so without any network connectivity to ensure no external inputs are used in a build.
After the update of 0.3.5.7 to 0.3.5.8 this broke 3 tests.

Maybe we should run a CI job without the network?
(It's probably not worth it for a once-off mistake like this, but if it keeps happening, let's consider it.)

comment:10 Changed 5 months ago by dgoulet

Status: needs_reviewmerge_ready

Still good.

comment:11 Changed 4 months ago by teor

I expect to merge this backport on Monday or Tuesday next week.

comment:12 Changed 4 months ago by teor

Resolution: fixed
Status: merge_readyclosed

This fix has been tested in 0.4.0 and master CI for about 3 weeks.

I just re-tested the backport to 0.3.5 on my local machine with the network off, and it fixes the test failure.

Merged to 0.3.5, and merged forward (but the commit is already in later releases).

Note: See TracTickets for help on using tickets.