Opened 3 months ago

Closed 3 months ago

#29532 closed enhancement (fixed)

Update pre-push hook so that only maint-* and release-* can get pushed to origin.

Reported by: nickm Owned by: rl1987
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: git-scripts dgoulet-merge
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description (last modified by teor)

See #29531 for motivation

Edit: correct ticket

Child Tickets

Change History (12)

comment:1 Changed 3 months ago by rl1987

Owner: set to rl1987
Status: newaccepted

comment:2 Changed 3 months ago by rl1987

Status: acceptedneeds_review

comment:3 Changed 3 months ago by nickm

Reviewer: nickm

comment:4 Changed 3 months ago by nickm

Status: needs_reviewneeds_revision

Hi! I left a couple of questions on the PR.

comment:5 Changed 3 months ago by nickm

Looking better; left another question.

comment:6 Changed 3 months ago by teor

Description: modified (diff)

comment:7 Changed 3 months ago by teor

I just opened #29547 and #29548 with related pre-push hook tasks. If they're handled by this ticket, please feel free to close them. Otherwise, let's handle them in separate pull requests?

comment:8 Changed 3 months ago by rl1987

Status: needs_revisionneeds_review

comment:9 Changed 3 months ago by nickm

Status: needs_reviewneeds_revision

I left one more question on the branch. This one might be pretty ignorant, since I don't know shell very well.

comment:10 Changed 3 months ago by rl1987

Status: needs_revisionneeds_review

comment:11 Changed 3 months ago by nickm

Keywords: dgoulet-merge added
Status: needs_reviewmerge_ready

This seems okay now. Let's squash and merge. (I say that we don't need another round of CI after the squash, since this doesn't touch any code that CI tests.)

comment:12 Changed 3 months ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

Merged to master! Thanks!

Note: See TracTickets for help on using tickets.