Opened 8 months ago

Closed 4 months ago

#29533 closed enhancement (fixed)

Lint all our shell scripts with shellcheck on CI

Reported by: rl1987 Owned by:
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: catalyst Sponsor:

Description (last modified by rl1987)

We have stuff in scripts directory being linted by shellcheck on every CI run, but not stuff in e.g. tests/ and contrib/. We should do so when we are done systematically cleaning up our shell scripts to make them pass shellcheck without any warnings.

Child Tickets

Change History (8)

comment:1 Changed 7 months ago by rl1987

Description: modified (diff)

comment:2 Changed 6 months ago by rl1987

Type: defectenhancement

I guess this is actually enhancement.

comment:3 Changed 5 months ago by rl1987

#30062 was a duplicate.

comment:4 Changed 4 months ago by rl1987

Status: newneeds_review

comment:5 Changed 4 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.4.2.x-final

comment:6 Changed 4 months ago by dgoulet

Reviewer: catalyst

comment:7 in reply to:  4 Changed 4 months ago by catalyst

Status: needs_reviewmerge_ready

Replying to rl1987:

https://github.com/torproject/tor/pull/1090

Looks good! Thanks!

comment:8 Changed 4 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged to master

Note: See TracTickets for help on using tickets.