Opened 5 months ago

Closed 5 months ago

#29542 closed enhancement (fixed)

Stop using weak_rng.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: dgoulet-merge
Cc: Actual Points: .1
Parent ID: Points: .1
Reviewer: asn Sponsor:

Description

We have crypto_fast_rng now, we should be able to use it everywhere that we were relying on our goofy old prng.

Child Tickets

Change History (5)

comment:1 Changed 5 months ago by nickm

Status: assignedneeds_review

See my branch no_weak_rng with PR at https://github.com/torproject/tor/pull/718. It is based on the branch from #29536.

comment:2 Changed 5 months ago by asn

Reviewer: asn

comment:3 Changed 5 months ago by asn

Status: needs_reviewmerge_ready

LGTM. Nitpick: Might be worth documenting what crypto_fast_rng_one_in_n() does.

comment:4 Changed 5 months ago by nickm

Keywords: dgoulet-merge added

I've added documentation to asn's request.

comment:5 Changed 5 months ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

Merged to master!

Note: See TracTickets for help on using tickets.